feat: 12-factored Indico replacing old charm#772
Draft
DeeKay3 wants to merge 1 commit into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has checked 204 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 33 | 2 | 169 | 0 |
Click to see the invalid file list
- charmcraft.yaml
- indico_rock/rockcraft.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| run-on: | ||
| - name: "ubuntu" | ||
| channel: "20.04" | ||
| # This file configures Charmcraft. |
Contributor
There was a problem hiding this comment.
Suggested change
| # This file configures Charmcraft. | |
| # Copyright 2026 Canonical Ltd. | |
| # See LICENSE file for licensing details. | |
| # This file configures Charmcraft. |
| @@ -1,98 +1,180 @@ | |||
| # Copyright 2025 Canonical Ltd. | |||
| # See LICENSE file for licensing details. | |||
| # Indico 12-factor rock built with the flask-framework Rockcraft extension. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Indico 12-factor rock built with the flask-framework Rockcraft extension. | |
| # Copyright 2026 Canonical Ltd. | |
| # See LICENSE file for licensing details. | |
| # Indico 12-factor rock built with the flask-framework Rockcraft extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
docs/release-notes/artifacts. If this PR does not require a change artifact, the PR has been tagged withno-release-note.urgent,trivial,complex)