charmcraft: mark non-required endpoints as optional#944
Open
rpbritton wants to merge 2 commits into
Open
Conversation
All provides endpoints on k8s and all provides/requires endpoints on k8s-worker (except cluster) are genuinely optional - the charm handles their absence gracefully without blocking: k8s (charms/worker/k8s/charmcraft.yaml): - provides: cos-agent, cos-worker-tokens, containerd, ceph-k8s-info, k8s-cluster, kube-control - requires: aws, azure, etcd, external-cloud-provider, gcp, external-load-balancer k8s-worker (charms/worker/charmcraft.yaml): - provides: cos-agent - requires: aws, azure, cos-tokens, containerd, gcp cluster (requires on k8s-worker) is intentionally not marked optional as _join_cluster raises BlockedStatus when it is absent.
k8s-cluster is the primary worker attachment endpoint and is part of the recommended deployment. Marking it optional would incorrectly signal to users that running without workers is the norm.
rpbritton
force-pushed
the
mark-optional-endpoints
branch
from
c0c59c6 to
a4e5f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optional: trueto endpoints that the charm handles gracefully without a relation and that are not part of the recommended deployment.Not marked optional:
k8s-cluster(provides, k8s) andcluster(requires, k8s-worker) - these are part of the standard multi-node setup or causeBlockedStatuswhen absent.