Add the login-unknown configuration option
#246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the option is set to True, LightDM proceeds to start the new session even if the username is unknown. Tend to be used with pam_mkuser.so PAM module. Signed-off-by: Paul Wolneykien <[email protected]>
global section Signed-off-by: Paul Wolneykien <[email protected]>
| /* Load user preferences */ | ||
| gboolean login_unknown = FALSE; | ||
|
|
||
| if (seat_get_string_property (seat, "login-unknown")) |
Collaborator
There was a problem hiding this comment.
Please add this into data/lightdm.conf with the default value and some documentation.
|
|
||
| /* Load user preferences */ | ||
| gboolean login_unknown = FALSE; | ||
|
|
Collaborator
There was a problem hiding this comment.
Nit: remove empty line.
Collaborator
|
This should also have a test, see |
Collaborator
|
Actually should really add two tests (empty username, one with config option and one without), as we weren't testing an empty username. |
Collaborator
|
Now I look at this a second time, I think the correct solution is to always allow this. I can't see a reason for us to fail at this point - it should fail in the PAM layer if the username is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the option is set to
True, LightDM proceeds to start the new session even if the username is not known. Intended to be used withpam_mkuser.soPAM module.