-
Notifications
You must be signed in to change notification settings - Fork 150
Add client library version for Qt6 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
|
Well, now CI is building a version for Qt6. Tests fail just like in main; tests added for Qt6 also fail. |
|
@robert-ancell, |
|
@Gliese852 yes, you will need to sign the CLA and you can use my name. Thanks! |
492c705 to
6fdda91
Compare
|
Squashed the fixup commits to at the same time provoke the launch of CI, at least the cla-check is now successful. |
|
Any updates with this PR? |
While upstream is working on QT6 support being added to lightdm it is decided to drop QT5 in the meantime as we have no supporting QT5 greeter in ::gentoo and was unable to find one in any third party repos. Once canonical/lightdm#373 is merged support will be added back. Closes: https://bugs.gentoo.org/953261 Signed-off-by: Ian Jordan <[email protected]>
While upstream is working on Qt6 support being added to lightdm it is decided to drop Qt5 in the meantime as we have no supporting Qt5 greeter in ::gentoo and was unable to find one in any third party repos. Once canonical/lightdm#373 is merged, support will be added back. * asturmlechner 2025-04-29: Actually configure w/ --disable-liblightdm-qt5 A common complaint for lightdm is that the package does not pull in X. This change adds an X USE flag to pull in x11-base/xorg-drivers. * asturmlechner 2025-04-29: mv to COMMON_DEPEND from RDEPEND+DEPEND Bug: https://bugs.gentoo.org/953261 Signed-off-by: Ian Jordan <[email protected]> Closes: #40329 Signed-off-by: Andreas Sturmlechner <[email protected]>
|
Any updates? |
|
It'd be great to see this land and released sooner rather than later, since the LightDM KDE Greeter requires this. |
Can lightdm package in Fedora adopted this PR as a patch to build against qt6? Since that OpenSUSE, ALT Linux added the qt6 library [1, 2] [1] https://build.opensuse.org/projects/X11:Utilities/packages/lightdm/files/lightdm-1.32.0-qt6-library.patch?expand=1 |
I would like to port
lightdm-kde-greeterto qt6, and this requires the corresponding lightdm library.I did not delete the version for qt5, the versions do not interfere with each other. The source code has not changed much, just updated the outdated
QString::toAsciimethod.Added an m4 macro to search for the
mocexecutable file to check the version. It seems that this will be more reliable if there are several of them in the system. For reference, I used macros from thefreecivproject. (qt6.m4)