fix: fix some memory leak in session_child_run #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
approved these changes
Dec 11, 2024
src/session-child.c
Outdated
| pam_putenv (pam_handle, g_strdup_printf ("LOGNAME=%s", username)); | ||
| pam_putenv (pam_handle, g_strdup_printf ("HOME=%s", user_get_home_directory (user))); | ||
| pam_putenv (pam_handle, g_strdup_printf ("SHELL=%s", user_get_shell (user))); | ||
| g_autofree char* user_env = g_strdup_printf ("USER=%s", username); |
Collaborator
There was a problem hiding this comment.
For consistency char -> gchar, but otherwise everything looks great! Looks like putenv requires the string to remain, but pam_putenv makes a copy which is why this leak was probably added.
Contributor
Author
There was a problem hiding this comment.
thanks you,I will correct the ‘char‘ to ‘gchar‘
The memory requested using g_strdup_printf is not released. Use g_autofree to release the memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory requested using g_strdup_printf is not released. Use g_autofree to release the memory.