Skip to content

github: combine gh pr view calls into a single one #18658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
morphis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

github: combine gh pr view calls into a single one #18658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/domain-reviewers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ jobs:
run: |
set -euo pipefail

# Fetch current PR labels.
mapfile -t PR_LABELS < <(gh pr view "${PR_NUMBER}" --repo "${REPO}" \
--json labels --jq '.labels[].name')
# Fetch current PR labels and requested reviewers in one shot.
PR_DATA=$(gh pr view "${PR_NUMBER}" --repo "${REPO}" \
--json labels,reviewRequests)

mapfile -t PR_LABELS < <(jq -r '.labels[].name // empty' <<< "${PR_DATA}")
mapfile -t CURRENT_REVIEWERS < <(jq -r '.reviewRequests[].login // empty' <<< "${PR_DATA}")

# Build the desired reviewer set: union of owners for every domain
# label currently on the PR, excluding the PR author, deduplicated.
Expand All @@ -54,10 +57,6 @@ jobs:
.github/domain-owners.json)
done

# Fetch current requested reviewers on the PR.
mapfile -t CURRENT_REVIEWERS < <(gh pr view "${PR_NUMBER}" --repo "${REPO}" \
--json reviewRequests --jq '.reviewRequests[].login')

# Determine reviewers to add (desired but not already requested).
ADD=()
for reviewer in "${!desired[@]}"; do
Expand Down
Loading