Impact
The LXD /1.0/images endpoint is implemented as an AllowUntrusted API that requires no authentication, making it accessible to users without accounts. This API allows determining project existence through differences in HTTP status codes when accessed with the project parameter.
|
var imagesCmd = APIEndpoint{ |
|
Path: "images", |
|
MetricsType: entity.TypeImage, |
|
|
|
Get: APIEndpointAction{Handler: imagesGet, AllowUntrusted: true}, |
|
Post: APIEndpointAction{Handler: imagesPost, AllowUntrusted: true}, |
|
} |
This configuration allows access without authentication:
|
if !trusted && !action.AllowUntrusted { |
|
return response.Forbidden(errors.New("You must be authenticated")) |
|
} |
This API returns a 404 error when accessing existing projects and a 403 error when accessing non-existent projects, allowing confirmation of project existence through this difference.
The problematic implementation is shown below.
First, in the error handling implementation of the imagesGet function below, project existence is checked within the projectutils.ImageProject function, and the err returned by the ImageProject function is directly returned to the user.
https://github.com/canonical/lxd/blob/43d5189564d27f6161b430ed258c8b56603c2759/lxd/i mages.go#L1781-L1788
When the project doesn't exist, the error is 404 (http.StatusNotFound), which is
returned to the user:
|
switch len(objects) { |
|
case 0: |
|
return nil, api.StatusErrorf(http.StatusNotFound, "Project not found") |
On the other hand, when the project exists but the user lacks viewing permissions, the imagesGet function returns 403 (response.Forbidden):
|
// Untrusted callers can't request images from all projects or projects other than default. |
|
if !trusted && (allProjects || projectName != api.ProjectDefaultName) { |
|
return response.Forbidden(errors.New("Untrusted callers may only access public images in the default project")) |
|
} |
Reproduction Steps
- Send the following request without authentication to a non-existent project:
curl -k "https://lxd-host:8443/1.0/images?project=XXX-project"
Response:
{"type":"error","status":"","status_code":0,"operation":"","error_code":404,"error":"fetch project: Project not found","metadata":null}
- Send a request without authentication to an existing project (if a public project exists, it will be included in the response):
curl -k "https://lxd-host:8443/1.0/images?project=exist-project"
Reponse:
{"type":"error","status":"","status_code":0,"operation":"","error_code":403,"error":"Untrusted callers may only access public images in the default project","metadata":null}
Risk
The attack requires only network access to the LXD API endpoint, with no authentication needed.
The attack allows confirming the existence of projects within the LXD system by exploiting differences in HTTP status codes.
This could potentially increase the exploitability of othervulnerabilities.
Additionally, since project IDs often use meaningful names set by users, this could lead to leakage of unpublished product information. However, resource information within projects cannot be obtained, limiting the impact to existence confirmation only.
Countermeasures
It is recommended to modify the error handling in the imagesGet function to return consistent responses regardless of project existence. Specifically, when an error occurs during project existence verification, the implementation should be changed to always return a 403 (Untrusted callers may only access public images in the default project) error to unauthenticated users.
This ensures that the same error response is returned for both existing and non-existing
projects, preventing determination of project existence.
Patches
| LXD Series |
Status |
| 6 |
Fixed in LXD 6.5 |
| 5.21 |
Fixed in LXD 5.21.4 |
| 5.0 |
Ignored - Not critical |
| 4.0 |
Ignored - EOL and not critical |
References
Reported by GMO Flatt Security Inc.
Impact
The LXD /1.0/images endpoint is implemented as an AllowUntrusted API that requires no authentication, making it accessible to users without accounts. This API allows determining project existence through differences in HTTP status codes when accessed with the project parameter.
lxd/lxd/images.go
Lines 63 to 69 in 43d5189
This configuration allows access without authentication:
lxd/lxd/daemon.go
Lines 924 to 926 in 43d5189
This API returns a 404 error when accessing existing projects and a 403 error when accessing non-existent projects, allowing confirmation of project existence through this difference.
The problematic implementation is shown below.
First, in the error handling implementation of the imagesGet function below, project existence is checked within the
projectutils.ImageProjectfunction, and the err returned by theImageProjectfunction is directly returned to the user.https://github.com/canonical/lxd/blob/43d5189564d27f6161b430ed258c8b56603c2759/lxd/i mages.go#L1781-L1788
When the project doesn't exist, the error is 404 (http.StatusNotFound), which is
returned to the user:
lxd/lxd/db/cluster/projects.mapper.go
Lines 237 to 239 in 43d5189
On the other hand, when the project exists but the user lacks viewing permissions, the imagesGet function returns 403 (response.Forbidden):
lxd/lxd/images.go
Lines 1796 to 1799 in 43d5189
Reproduction Steps
Response:
{"type":"error","status":"","status_code":0,"operation":"","error_code":404,"error":"fetch project: Project not found","metadata":null}Reponse:
Risk
The attack requires only network access to the LXD API endpoint, with no authentication needed.
The attack allows confirming the existence of projects within the LXD system by exploiting differences in HTTP status codes.
This could potentially increase the exploitability of othervulnerabilities.
Additionally, since project IDs often use meaningful names set by users, this could lead to leakage of unpublished product information. However, resource information within projects cannot be obtained, limiting the impact to existence confirmation only.
Countermeasures
It is recommended to modify the error handling in the imagesGet function to return consistent responses regardless of project existence. Specifically, when an error occurs during project existence verification, the implementation should be changed to always return a 403 (Untrusted callers may only access public images in the default project) error to unauthenticated users.
This ensures that the same error response is returned for both existing and non-existing
projects, preventing determination of project existence.
Patches
References
Reported by GMO Flatt Security Inc.