Skip to content

Update source link and fix CI issues #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 12, 2024
Merged

Update source link and fix CI issues #29

merged 12 commits into from
Nov 12, 2024

Conversation

@swetha1654
Copy link
Contributor

@swetha1654 swetha1654 commented Nov 11, 2024 •
edited
Loading

Applicable spec:

Overview

  • The source link present in metadata.yaml has a typo. Fixing that typo.
  • Also added websockets<14.0 since the integration tests were failing due to this issue
  • Made changes to install the plugins irrespective of the image flavor
  • Added vulnerabilities to .trivyignore

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@swetha1654 swetha1654 requested a review from a team as a code owner November 11, 2024 06:29
weiiwang01
weiiwang01 previously approved these changes Nov 11, 2024
View reviewed changes
cbartz
cbartz previously approved these changes Nov 11, 2024
View reviewed changes
Copy link

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a really trivial PR, I know, but please fill in the PR description and the checkboxes next time.

@swetha1654 swetha1654 dismissed stale reviews from cbartz and weiiwang01 via 6154ca2 November 11, 2024 08:23
jdkandersson
jdkandersson previously approved these changes Nov 11, 2024
View reviewed changes
arturo-seijas
arturo-seijas previously approved these changes Nov 12, 2024
View reviewed changes
@swetha1654 swetha1654 changed the title Update metadata.yaml to have the right source link Update source link and fix CI issues Nov 12, 2024
@swetha1654 swetha1654 merged commit 217e4bf into main Nov 12, 2024
16 checks passed
@swetha1654 swetha1654 deleted the swetha1654-patch-1 branch November 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@cbartz cbartz Awaiting requested review from cbartz

@weiiwang01 weiiwang01 Awaiting requested review from weiiwang01

+1 more reviewer

@jdkandersson jdkandersson jdkandersson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

trivial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swetha1654 @cbartz @weiiwang01 @jdkandersson @arturo-seijas