Strict patch - #2996
Open
ktsakalozos wants to merge 3 commits into
Open
Conversation
berkayoz
force-pushed
the
strict
branch
2 times, most recently
from
June 6, 2022 07:29
581832b to
c792a24
Compare
berkayoz
force-pushed
the
strict
branch
2 times, most recently
from
June 14, 2022 14:34
af9a253 to
b9f7523
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
June 23, 2022 09:34
63b60ef to
0b9e05c
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
July 7, 2022 12:43
6e11084 to
c2febba
Compare
neoaggelos
force-pushed
the
strict
branch
4 times, most recently
from
August 5, 2022 06:27
40d85ce to
2a473c1
Compare
ktsakalozos
force-pushed
the
strict
branch
3 times, most recently
from
August 26, 2022 03:59
050b132 to
432e218
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
August 30, 2022 11:07
e3a8ab0 to
6b7eb03
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
December 9, 2022 08:55
a523188 to
dec5f23
Compare
ktsakalozos
force-pushed
the
strict
branch
4 times, most recently
from
June 11, 2023 11:07
8a87574 to
65c90fb
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
July 21, 2023 10:03
3ea12aa to
67ff7c9
Compare
neoaggelos
force-pushed
the
strict
branch
2 times, most recently
from
August 2, 2023 06:01
c73c1b1 to
9da7473
Compare
sachinkumarsingh092
force-pushed
the
strict
branch
3 times, most recently
from
August 2, 2023 12:28
78ea2e9 to
90f6baf
Compare
ktsakalozos
force-pushed
the
strict
branch
3 times, most recently
from
August 15, 2023 12:17
2ac37e6 to
8377214
Compare
neoaggelos
force-pushed
the
strict
branch
2 times, most recently
from
November 3, 2023 09:43
55fd479 to
1bda041
Compare
ktsakalozos
force-pushed
the
strict
branch
2 times, most recently
from
July 11, 2024 16:25
0856565 to
6286626
Compare
Signed-off-by: Homayoon (Hue) Alimohammadi <homayoon.alimohammadi@canonical.com>
…_init (strict) (#5552) * fix(runc): apply AppArmor profile after finalizeNamespace in standard_init Reorders the strict-mode runc v1.4.2 patch so the AppArmor profile change (and NoNewPrivileges) happen after finalizeNamespace runs setuid(2), mirroring setns_init_linux. Because the strict patches switch the profile immediately (aa_change_profile) instead of on exec, relabelling before setuid left the Go runtime's sibling threads under snap.microk8s.daemon-containerd while the calling thread moved to cri-containerd.apparmor.d. glibc's NPTL setxid broadcast (SIGRTMIN+1) then crossed two AppArmor profiles and was denied by AppArmor 4.x, breaking pod creation for workloads with allowPrivilegeEscalation: false (e.g. metallb). Doing setuid(2) while all threads share one profile keeps the broadcast intra-profile and resolves the denials without any snapd changes. * ci: grant security-events write permission for SARIF upload The upload_sarifs_matrix job runs codeql-action/upload-sarif, which requires security-events: write. With no permissions block declared the token fell back to the restricted default and uploads failed with "Resource not accessible by integration". Add a job-scoped permissions block granting the minimal scopes needed (contents/actions read, security-events write). * ci: normalize permission comment formatting in build-snap workflow --------- Co-authored-by: Konstantinos Tsakalozos <kos.tsakalozos@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict patches