Skip to content

Conversation

@maci3jka
Copy link
Contributor

@maci3jka maci3jka commented Nov 27, 2024

Summary

The Trivy job started failing due to changes in trivi action code. This PR gets rid of that action and replaces it with usage of trivy binary since it is used in next steps as well.

Changes

  • Replaces Trivy install script with action installing it
  • Replaces scan action with script working in the same way
  • Updates upload-sarif action version to 3

Testing

Possible Regressions

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

@maci3jka maci3jka requested review from a team, ktsakalozos and louiseschmidtgen November 27, 2024 13:21
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing the failing test!

@maci3jka maci3jka merged commit ff13a81 into master Nov 27, 2024
12 checks passed
@maci3jka maci3jka deleted the KU-2230/trivy-job-fix branch November 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants