[cli] Minimize non-live effects on spinner

Maintain locks and running state in spinner, even when non-live.

Author: ricab

src/client/cli/cmd/animated_spinner.cpp

@@ -42,21 +42,21 @@ mp::AnimatedSpinner::~AnimatedSpinner()
 
 void mp::AnimatedSpinner::start(const std::string& start_message)
 {
-    if (!is_live)
-    {
-        current_message = start_message;
-        cout << start_message << std::flush;
-        return;
-    }
-
     std::unique_lock<decltype(mutex)> lock{mutex};
+
     if (!running)
     {
         current_message = start_message;
         running = true;
-        clear_line(cout);
-        cout << start_message << "  " << std::flush;
-        t = std::thread(&AnimatedSpinner::draw, this);
+
+        if (is_live)
+        {
+            clear_line(cout);
+            cout << start_message << "  " << std::flush;
+            t = std::thread(&AnimatedSpinner::draw, this);
+        }
+        else
+            cout << start_message << std::flush;
     }
 }
 
@@ -68,19 +68,21 @@ void mp::AnimatedSpinner::start()
 
 void mp::AnimatedSpinner::stop()
 {
-    if (!is_live)
-        return;
-
     std::unique_lock<decltype(mutex)> lock{mutex};
     if (running)
     {
         running = false;
-        cv.notify_one();
-        lock.unlock();
-        if (t.joinable())
-            t.join();
+        if (is_live)
+        {
+            cv.notify_one();
+            lock.unlock();
+            if (t.joinable())
+                t.join();
+        }
     }
-    clear_line(cout);
+
+    if (is_live)
+        clear_line(cout);
 }
 
 void mp::AnimatedSpinner::print(std::ostream& stream, const std::string& message)