-
Notifications
You must be signed in to change notification settings - Fork 736
Az networking Linux #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Az networking Linux #4071
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## availability-zones #4071 +/- ##
======================================================
+ Coverage 89.48% 89.50% +0.02%
======================================================
Files 268 268
Lines 18003 18034 +31
======================================================
+ Hits 16110 16142 +32
+ Misses 1893 1892 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
06b9b28 to
9de8b73
Compare
4e7f1b7 to
66fede5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid piece of work @Sploder12! I have a couple of comments.
b8474ed to
89a39fd
Compare
aab0a54 to
25fbb69
Compare
2331482 to
3c8321a
Compare
29bbe5a to
d500e33
Compare
| namespace multipass | ||
| { | ||
| class QemuPlatform : private DisabledCopyMove | ||
| class QemuPlatform : protected DisabledCopyMove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the only use of protected DisabledCopyMove in the entire multipass codebase. Is there a reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, QemuPlatformDetail::Subnet needs to derive DisabledCopyMove and because QemuPlatform already derives it as private QemuPlatformDetail::Subnet cannot access it. But it turns out this is because name lookup is going for the derived DisabledCopyMove and not multipass::DisabledCopyMove so being explicit removes the need to make this protected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested by launching a MySQL replication setup with SSL across 2 VMs in different zones and there were no issues with networking
f21b770 to
3098c8f
Compare
2cc88d6 to
9bf85cc
Compare
3098c8f to
6c91f0b
Compare
9bf85cc to
1c7540d
Compare
-1 is not a valid value for --count (-c). We were interpreting ping's invalid value return as failing to ping.
127fa41 to
bf74556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Tested locally, VM gets its IP address from AZ1. Also, the branch passes all the CLI tests too.
I've noticed that it takes longer to start the daemon on the first start, but the time is rather negligible. The subsequent daemon starts does not suffer from this.
Adds subnets to AZs and assigns them to VMs made in that zone. This PR only covers Linux QEMU using dnsmasq.
MULTI-1942