-
Notifications
You must be signed in to change notification settings - Fork 736
Update Qt #4390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4390 +/- ##
==========================================
+ Coverage 88.97% 89.43% +0.45%
==========================================
Files 238 240 +2
Lines 15253 13851 -1402
==========================================
- Hits 13572 12387 -1185
+ Misses 1681 1464 -217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
7f1947d to
2d4282a
Compare
badcff1 to
4ec88e4
Compare
In Qt 6.8, this function's behavior changed, which would force us to work around those changes. Since we plan to remove our dependency on Qt, we replace these calls with `std::filesystem` calls instead.
8c41795 to
4a8c329
Compare
|
How do you feel about moving to Qt 6.10 right away? Or, was there a specific reason for using 6.9? |
I'm not strongly opposed, though Ubuntu 25.10 uses Qt 6.9.2, so sticking with the 6.9 series on Mac and Windows would mean less version skew on our official builds ( |
FTR I plan to migrate the QT to vcpkg too after this one lands, so feel free to use the latest and the greatest. |
|
|
||
| - `C:\Program Files\CMake\bin` | ||
| - `C:\Qt\6.2.4\msvc2019_64\bin` | ||
| - `C:\Qt\6.10.0\bin` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The directory structure for the qtbase binary archive is different now.
5736e9b to
dc53386
Compare
70ed8d4 to
c6ece3c
Compare
The binaries we used from the previous version were built with C++14 on macOS, preventing us from using Qt's `std::filesystem` integration.

Spinning this off from the update to C++20 to nail down some strange behavior on macOS.