[rust] Petname implementation and rust infrastructure#4600
Open
[rust] Petname implementation and rust infrastructure#4600
Conversation
tobe2098
force-pushed
the
petname-rust-implementation
branch
2 times, most recently
from
d3e47ea to
83258c7
Compare
ricab
reviewed
Jan 7, 2026
tobe2098
force-pushed
the
petname-rust-implementation
branch
4 times, most recently
from
ac25aa1 to
da314c5
Compare
tobe2098
changed the title
tobe2098
force-pushed
the
petname-rust-implementation
branch
17 times, most recently
from
d31d169 to
95f35ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
+ Coverage 87.25% 87.26% +0.02%
==========================================
Files 269 271 +2
Lines 16212 16212
==========================================
+ Hits 14144 14146 +2
+ Misses 2068 2066 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tobe2098
force-pushed
the
petname-rust-implementation
branch
2 times, most recently
from
8b569c1 to
f4de456
Compare
Procedural macros cannot be in the same crate where they are used, so they need to be separated from the using crate, petname in this case.
Remove the old implementation of petname and its tests.
There were some idiomatic errors that made the code hard to read and understand. Some repeated code was also removed.
For future use with disk name generation, the interface will not only be used for petnames, so the crate should be general on name generation
Main changes are comments, a cleaner way to check for characters in Rust and a change in installation of Rust during `snapcraft pack`
xmkg
requested changes
Apr 22, 2026
Member
xmkg
left a comment
xmkg
left a comment
There was a problem hiding this comment.
Thanks for sorting out the coredump handling in CI! I have a couple of comments regarding the cargo profiles, and a small typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
MULTI-2452