Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@seb4stien
Copy link
Contributor

Fix vale issues.

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seb4stien
Copy link
Contributor Author

Juju 3.x seems to do the job indeed. And using the backticks on the version too: Juju 3.
@erinecon any recommendation on what we should align on?

@erinecon
Copy link
Contributor

erinecon commented Jul 9, 2025

Juju 3.x seems to do the job indeed. And using the backticks on the version too: Juju 3. @erinecon any recommendation on what we should align on?

Hi @seb4stien , I would use Juju 3.x

@erinecon erinecon added the documentation Improvements or additions to documentation label Jul 9, 2025
Lint

Simplify

Update charm/docs/explanation/charm-architecture.md

Co-authored-by: Dima Tisnek <[email protected]>
@erinecon
Copy link
Contributor

Hi @seb4stien,

For transparency, I fixed some initial discourse-gatekeeper failures by converting all the Discourse posts to Wiki articles.

Now the failure is:

problem: detected unmerged community contributions, these need to be resolved before proceeding.  
Paths with potentially unmerged community contributions: {'tutorial/testing-netbox', 'explanation/charm-architecture', 
'tutorial/getting-started', 'how-to/contribute', 'how-to/configure-saml'}.

I recommend that you compare the relevant Discourse posts with the changes in this PR and make sure they match. Then you can re-trigger the workflow, and it should pass.

@github-actions
Copy link
Contributor

Test results for commit a2dd5e3

Test coverage for a2dd5e3

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      1      2      1    78%   20
----------------------------------------------------------
TOTAL              7      1      2      1    78%

Static code analysis report

Run started:2025-07-15 15:12:02.668300

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 671
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@seb4stien seb4stien merged commit 35faeef into main Jul 15, 2025
18 of 19 checks passed
@seb4stien seb4stien deleted the doc/vale branch July 15, 2025 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation Libraries: Out of sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants