Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@erinecon
Copy link
Contributor

@erinecon erinecon commented Aug 6, 2025

Applicable ticket: ISD-3949

Overview

Run Vale checks locally and fix errors.

Rationale

There's a bug in operator-workflows that points to an older version of the Canonical Vale style checks. Therefore some of the checks will be missed in the GitHub CI.

Juju Events Changes

None

Module Changes

None

Library Changes

None

Checklist

There are no src docs.
Either discourse-gatekeeper will update the documentation on Charmhub or I'll do it after the approval of this PR.

@erinecon erinecon requested a review from a team as a code owner August 6, 2025 20:12
@erinecon erinecon requested review from dimaqq and f-atwi August 6, 2025 20:12
@erinecon erinecon added the documentation Improvements or additions to documentation label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Test results for commit aa51053

Test coverage for aa51053

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      1      2      1    78%   20
----------------------------------------------------------
TOTAL              7      1      2      1    78%

Static code analysis report

Run started:2025-08-06 20:15:12.468012

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 671
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@dimaqq dimaqq removed their request for review August 8, 2025 02:02
@erinecon erinecon merged commit 0b96f6a into main Aug 8, 2025
26 of 28 checks passed
@erinecon erinecon deleted the vale-checks branch August 8, 2025 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants