Skip to content

chore(ruby): promote to stable #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

chore(ruby): promote to stable #655

merged 1 commit into from
Oct 14, 2025

Conversation

@cjdcordeiro
Copy link
Collaborator

Promote Ruby to stable.

alesancor1
alesancor1 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@alesancor1 alesancor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though why are we manually doing chisel cut instead of using stage-packages?

@lczyk
Copy link
Contributor

lczyk commented Oct 14, 2025

why are we manually doing chisel cut instead of using stage-packages?

i believe because build-base != target-base so stage would pull in 24.04 instead of 25.04

lczyk
lczyk approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

zhijie-yang
zhijie-yang approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@zhijie-yang zhijie-yang merged commit ce52f75 into main Oct 14, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhijie-yang zhijie-yang zhijie-yang approved these changes

@lczyk lczyk lczyk approved these changes

@alesancor1 alesancor1 alesancor1 approved these changes

@ROCKsBot ROCKsBot Awaiting requested review from ROCKsBot ROCKsBot is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjdcordeiro @lczyk @zhijie-yang @alesancor1