-
Notifications
You must be signed in to change notification settings - Fork 64
simplify WSL tutorial #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- remove steps that are probably not necessary (e.g., checking systemd from PowerShell) - reduces complexity in web app (e.g., no CSS) - provides an example of what VSCode offers (e.g., snippets) - shortens section on interoperability (e.g., focus on terminal-based moving of image from Windows) - increase emphasis on built-in tooling at the start - favour terminal commands over GUI where appropriate (e.g., Windows terminal keybinding, instead of chevron) - avoid confusing naming ("UbuntuWSL" is not a helpful name for the web project) - various small fixes and adjustments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @edibotopic. This is great! I genuinely like how you were able to cut out the fluff and help the reader focus on the necessary aspects of the tutorial.
I left some comments already, but there are a few extra you might want to look into:
- Since you changed the web example, some of the images no longer align and need to be changed
- Some of the text formatting seems a bit off, particularly the notes. Perhaps it's a convention I'm unaware of
I think that's about it for now. Great work!
the latest distros are installed without the -d flag and open after installation.
so that the user can clean up their environment
Thanks a lot for your insightful and helpful comments @ade555 --- I have applied the majority of your suggestions. I also made a slight update for install instructions and added a tear-down section. We should be able to wrap up this phase of the work now, which will help put a much better shape on the future WSL tutorial. Due to some of the recent changes in how WSL distros are packaged, and our plans for the launch of Pro for WSL, there may still be some planning and work to get this tutorial right for our users. Once we have finalised a version, I will credit you for your contribution and so that you can see the final direction that we took. If you're happy with the changes above, let me know. ps: do you know about the Suggest Changes feature on GitHub? It's very useful: https://haacked.com/archive/2019/06/03/suggested-changes/ Edit: on the screenshots, I'm going to leave them, because that's an aspect that is probably going to change a few times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @edibotopic. Thank you very much for the changes. Overall, I think we're good to go.
I left some tiny suggestions you might want to look into. Beyond that, it's all good to me.
I can't wait to see the final tutorial!!
Co-authored-by: SuperheroJT <[email protected]>
Co-authored-by: SuperheroJT <[email protected]>
Co-authored-by: SuperheroJT <[email protected]>
Closes #201
Continues work started by @ade555 to improve the WSL tutorial.
Main changes:
UDENG-6579