refactor: Address review comments on #100 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelallan72
suggested changes
Sep 16, 2024
- Revert charmcraft version from v3 -> v2 on checking - Document wording changes
Raise SnapConfigurationMissingError when snap configuration is empty
jneo8
requested review from
Deezzir,
Pjack,
aieri,
chanchiwai-ray,
gabrielcocenza,
rgildein and
samuelallan72
jneo8
force-pushed
the
refactor/charm-review
branch
from
9ed9d87 to
9e39416
Compare
samuelallan72
previously approved these changes
Sep 20, 2024
Remove SnapConfigurationMissingError and raise SnapError directly
samuelallan72
previously approved these changes
Sep 20, 2024
chanchiwai-ray
previously approved these changes
Sep 20, 2024
jneo8
dismissed stale reviews from chanchiwai-ray and samuelallan72
via
2388359
chanchiwai-ray
approved these changes
Sep 20, 2024
samuelallan72
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# TODO: can we remove the base64 encoding?on.github/workflows/check.yamlopenstack-exporterandsnap_channelare set.