Add inline comments to trivy ignore #847

alithethird · 2025-10-10T11:56:38Z

Overview

Trivy ignore unused was parsing the inline comments wrong and creating false positives for unused ignore lines.

Rationale

Workflow Changes

Checklist

The contributing guide was applied
The PR is tagged with appropriate label (urgent, trivial, complex)
The changelog is updated with user-relevant changes in the format of keep a changelog v1.1.0

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:07Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:08Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:08Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:08Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:08Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions

license-eye has checked 115 files.

Valid	Invalid	Ignored	Fixed
26	1	88	0

Click to see the invalid file list

yarn.lock

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

github-actions · 2025-10-15T10:55:09Z

yarn.lock

@@ -0,0 +1,5027 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


Suggested change

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

# Copyright 2025 Canonical Ltd.

# See LICENSE file for licensing details.

# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

github-actions · 2025-10-24T08:09:43Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:49.318654

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:43Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:17.890181

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:44Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:52.705536

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:44Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:19.993661

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:45Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:47.021592

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:46Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:22.841116

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:09:46Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:03:39.176200

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:16Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:49.318654

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:17Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:17.890181

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:18Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:52.705536

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:18Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:19.993661

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:19Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:47.021592

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:20Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:01:22.841116

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2025-10-24T08:10:20Z

Test results for commit `98376c1`

Test coverage for 98376c1

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      7      0      0     0%   8-23
----------------------------------------------------------
TOTAL              7      7      0      0     0%

Static code analysis report

Run started:2025-10-24 08:03:39.176200

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 52
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

alithethird added 3 commits October 10, 2025 12:33

Fix: Trivy command parse.

224ded8

Fix: Oops

ea95c95

Chore: Support inline comments

6a8cdb6

alithethird requested a review from a team as a code owner October 10, 2025 11:56

alithethird requested a review from Thanhphan1147 October 10, 2025 11:56

alithethird and others added 7 commits October 10, 2025 14:57

Chore: revert the trivy command

c921492

Chore: oops

1063abe

Merge branch 'main' into fix/trivy-non-used

7946e34

Chore: test magic

ec295c5

Chore: remove magic

a417d01

Chore: test

5e3e363

Chore: revert test

e300a02

alithethird marked this pull request as draft October 14, 2025 12:31

test out different files

85e147e

github-actions bot reviewed Oct 15, 2025

View reviewed changes

alithethird added 7 commits October 15, 2025 14:22

Use correct ignores.

6472286

Use correct ignores.

a205a90

Use correct ignores.

f723843

Test: Add debug log

f717f19

Test: Add debug log

91ea691

Test: try to fix

a510dc6

Test: try to fix

98376c1

		@@ -0,0 +1,5027 @@
		# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

Add inline comments to trivy ignore #847

Are you sure you want to change the base?

Add inline comments to trivy ignore #847

Uh oh!

Conversation

alithethird commented Oct 10, 2025

Overview

Rationale

Workflow Changes

Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

github-actions bot commented Oct 24, 2025

Test results for commit 98376c1

Uh oh!

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`

Test results for commit `98376c1`