Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use noun relation and verb integrate #1574

Conversation

james-garner-canonical
Copy link
Contributor

Update documentation, mostly the content that used to be on Discourse, to use the noun form relation and the verb integrate.

ops/model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! A couple of small queries/suggestions.

I read through all these, but did not go searching for any ones that might have been missed. I think if there are any, we just handle them when found.

docs/explanation/charm-relation-interfaces.md Outdated Show resolved Hide resolved
docs/howto/write-unit-tests-for-a-charm.md Outdated Show resolved Hide resolved
ops/charm.py Outdated Show resolved Hide resolved
ops/model.py Show resolved Hide resolved
ops/model.py Outdated Show resolved Hide resolved
testing/src/scenario/state.py Outdated Show resolved Hide resolved
Thanks, Tony!

Co-authored-by: Tony Meyer <[email protected]>
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but approving, as I don't have very strong feelings about any of them.

docs/explanation/charm-relation-interfaces.md Outdated Show resolved Hide resolved
docs/howto/write-integration-tests-for-a-charm.md Outdated Show resolved Hide resolved
ops/charm.py Outdated Show resolved Hide resolved
ops/model.py Show resolved Hide resolved
@james-garner-canonical james-garner-canonical merged commit 8f25088 into canonical:main Feb 13, 2025
32 checks passed
dwilding added a commit to dwilding/canonical-operator that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants