feat: port the venv hotfix for https://bugs.launchpad.net/juju/+bug/2058335 #1634
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
added a commit
to dimaqq/operator
that referenced
this pull request
Mar 14, 2025
|
Huh, fails on Py 3.8 with |
|
Worth a quick discussion in daily on Monday, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/canonical/tempo-coordinator-k8s-operator/blame/42bd218789af89fb349f87a70267e6f52123c616/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py#L237-L252
Moved out from #1612
Ref: https://bugs.launchpad.net/juju/+bug/2058335
Why adopt it
There are deployed apps that cannot be upgraded to
ops[tracing]without it.The fix on the Juju side works at deploy time, meaning that a machine charm that was originally deployed with older Juju is still in a broken state. The Juju change doesn't fix those.
Why not adopt it
K8s charms are not affected, because a new pod is provisioned on charm upgrade.
There's a command-line
juju execfix for deployed machine charms (ssh into charm, find empty dirs, nuke them).