Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port the venv hotfix for https://bugs.launchpad.net/juju/+bug/2058335 #1634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Mar 14, 2025

https://github.com/canonical/tempo-coordinator-k8s-operator/blame/42bd218789af89fb349f87a70267e6f52123c616/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py#L237-L252

Moved out from #1612

Ref: https://bugs.launchpad.net/juju/+bug/2058335

⚠️ discussion needed if we want to adopt this fix ⚠️

Why adopt it

There are deployed apps that cannot be upgraded to ops[tracing] without it.

The fix on the Juju side works at deploy time, meaning that a machine charm that was originally deployed with older Juju is still in a broken state. The Juju change doesn't fix those.

Why not adopt it

K8s charms are not affected, because a new pod is provisioned on charm upgrade.

There's a command-line juju exec fix for deployed machine charms (ssh into charm, find empty dirs, nuke them).

dimaqq added a commit to dimaqq/operator that referenced this pull request Mar 14, 2025
@dimaqq
Copy link
Contributor Author

dimaqq commented Mar 14, 2025

Huh, fails on Py 3.8 with AttributeError: 'PathDistribution' object has no attribute '_normalized_name'. I'll need to dig into API differences between that and newer Pythons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant