chore: bump pre-commit versions, plus small fixes #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-garner-canonical
approved these changes
Mar 23, 2025
|
Happy with this. I'm not quite sure though -- why aren't these things caught in CI by the ruff checks there? |
|
I think it's because this jumps to using the latest |
dimaqq
approved these changes
Mar 25, 2025
| @@ -361,7 +361,7 @@ def _on_cluster_relation_changed(self, event: ops.EventBase): | |||
| harness.set_leader(False) | |||
| harness.update_relation_data(rel_id, 'test-app', {'k': 'v3'}) | |||
| assert backend.relation_get(rel_id, 'test-app', is_app=True) == {'k': 'v3'} | |||
| assert len(harness.charm.observed_events), 1 | |||
| assert len(harness.charm.observed_events) == 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly simplest to review commit by commit.
This bumps the versions of the pre-commit tools.
A few small issues are also fixed (this is somewhat a subset of #1474, skipping all the docs and controversial changes).
" "breaks).