This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Require a database for Django to start #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
In Django there is always a
manage.pyfile. This file is created by thedjango-admincommand, and will be used by the charm to run the migrations.As so, if there is no database integration correctly configured, the migration will fail (we do not support the sqlite3 local database). Many of the default Django apps (admin/sessions/auth) use the database, so the database is expected to be correctly configured.
This PR blocks the charm if there is no database integration correctly configured for Django. This can be for two reasons, one is no database defined in
charmcraft.yaml, the other is that there is only optional databases that were not integrated.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docsurgent,trivial,complex)