Add safeguard to prevent race condition #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deezzir
force-pushed
the
SOLENG-1142-unit-test-not-success-every-time
branch
2 times, most recently
from
7731956 to
96dac85
Compare
Deezzir
force-pushed
the
SOLENG-1142-unit-test-not-success-every-time
branch
from
96dac85 to
1d944a1
Compare
Deezzir
requested review from
Pjack,
Vultaire,
chanchiwai-ray,
gabrielcocenza,
jneo8,
samuelallan72 and
sbparke
Deezzir
changed the title
jneo8
previously approved these changes
Mar 26, 2025
jneo8
approved these changes
Mar 26, 2025
chanchiwai-ray
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a safeguard for each IPMISelCollector unit test. It waits until the
get_sel_entriesfunction is called once and then proceeds. This should prevent a race condition that @jneo8 discovered and generally make the test more robust.Closes: #93