Redesign IPMI SEL collector #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be more interesting cases to deal with e.g. timezone issue and `PostInit` in `Date` and `Time` field for the SEL entry.
chanchiwai-ray
added a commit
to canonical/hardware-observer-operator
that referenced
this pull request
May 28, 2025
The changes is a result of the re-design of ipmi-sel collector [1]. [1]: canonical/prometheus-hardware-exporter#99
chanchiwai-ray
requested review from
Deezzir,
H-M-Quang-Ngo,
Pjack,
Vultaire,
gabrielcocenza,
jneo8 and
samuelallan72
gabrielcocenza
requested changes
Jun 4, 2025
Add one more event with same name and type (essentially same timeseries), and show that we only get the latest one.
gabrielcocenza
previously approved these changes
Jun 6, 2025
gabrielcocenza
approved these changes
Jun 9, 2025
jneo8
approved these changes
Jun 11, 2025
chanchiwai-ray
added a commit
to canonical/hardware-observer-operator
that referenced
this pull request
Jun 11, 2025
* Update alert rules. The changes is a result of the re-design of ipmi-sel collector [1]. [1]: canonical/prometheus-hardware-exporter#99 * Update alert rules for ipmi sel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create one metric family for each state (nominal, warning, critical). These metrics now returns the event ID for each state; it will allow alert rule to carry more important information: event ID