Merged
Conversation
056fbc1 to
8afa87e
Compare
jdkandersson
approved these changes
Mar 3, 2025
medubelko
reviewed
Mar 6, 2025
docs/how-to/extensions/configure-the-build-base-for-expressjs-app.rst
Outdated
Show resolved
Hide resolved
docs/how-to/extensions/configure-the-build-base-for-expressjs-app.rst
Outdated
Show resolved
Hide resolved
docs/how-to/extensions/configure-the-build-base-for-expressjs-app.rst
Outdated
Show resolved
Hide resolved
docs/how-to/extensions/configure-the-build-base-for-expressjs-app.rst
Outdated
Show resolved
Hide resolved
Member
Author
Thanks for the comment! To clarify, the application "installation" is done by the NPM plugin - which involves two things:
Then, NodeJS provides a runtime in which the application is loaded and served. Would this make a difference in how we phrase the above? |
Contributor
Yes. :) Let me try again:
|
jdkandersson
approved these changes
Mar 6, 2025
tigarmo
approved these changes
Mar 6, 2025
Collaborator
tigarmo
left a comment
There was a problem hiding this comment.
Thanks! Approved pending the linting fix
tigarmo
reviewed
Mar 6, 2025
Collaborator
|
I think the breakage came in from the update in |
88937b5 to
5374920
Compare
jdkandersson
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for ExpressJS framework.
Key Decisions
bareand24.04only. Drop support for 22.04 (jammy)??operator commonly used in JS projects. This means that the projects initialized withexpress-generatortooling (assumed to be the case) would not work.expressjs-framework/install-app > stage-packagespart.expressjs-framework/runtimeexists to cater to apt packages, since slices and apt packages cannot be used together by design. See [wishlist] separate stage-packages and stage-slices #785.libdirectory of apt/slice installs. Remove the offering until the issue is resolved. See different contents or permissions error #790.npm-include-nodeandnpm-node-versionfields.app/directory.apppath (e.g. .env files)