forked from diddlesnaps/snapcraft-container
-
Notifications
You must be signed in to change notification settings - Fork 0
Add core24 to the workflow matrix #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the fork with new authors for reachout and move to ghcr
Minor: fix as -> AS, kw should all be uppercase
7fc4df5 to
f8fd167
Compare
5a83957 to
7c75d27
Compare
7c75d27 to
5bf1ec4
Compare
34855c2 to
f802509
Compare
f802509 to
198ed73
Compare
a5e7d02 to
59522f1
Compare
Minor: Update the triggering condition of the workflows
Turns out thiese are useful for core16 builds
5f84a57 to
6ea07d7
Compare
60f0b70 to
e889c6f
Compare
p-gentili
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a double space to fix
e889c6f to
6ea07d7
Compare
|
Cancelling the pipeline as the change is not really consequential |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first update required to support core24:
This also removes the following:
Removes amd64 as I currently see no point in cross building for amd64Re added, makes sense for VM builds of core16Passing tests: (tests are failing on the pr because I cancelled them to save some runner time and allow my other repo to get the runners)