Skip to content

extensions: simplifies the platform plug #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soumyaDghosh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

extensions: simplifies the platform plug #5109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d267d3
extensions: simplifies the platform plug
soumyaDghosh Oct 10, 2024
2b7df7b
Merge branch 'main' into command-chain-revamp
mr-cal Jan 15, 2025
8758bac
Merge branch 'main' into command-chain-revamp
mr-cal Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/desktop/command-chain/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ GPU_WRAPPER :=
scripts = hooks-configure-fonts desktop-launch run $(GPU_WRAPPER)

*:
sed -e "s/%PLATFORM_PLUG%/$${PLATFORM_PLUG:?}/" -i desktop-launch hooks-configure-fonts
install -D -m755 "$@" "$(BIN_DIR)"/"$@"

install: $(scripts)
Expand Down
2 changes: 1 addition & 1 deletion extensions/desktop/command-chain/desktop-launch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash

set -- "${SNAP}/gnome-platform/command-chain/desktop-launch" "$@"
set -- "${SNAP}/%PLATFORM_PLUG%/command-chain/desktop-launch" "$@"
# shellcheck source=/dev/null
source "${SNAP}/snap/command-chain/run"
2 changes: 1 addition & 1 deletion extensions/desktop/command-chain/hooks-configure-fonts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash

set -- "${SNAP}/gnome-platform/command-chain/hooks-configure-fonts" "$@"
set -- "${SNAP}/%PLATFORM_PLUG%/command-chain/hooks-configure-fonts" "$@"
# shellcheck source=/dev/null
source "${SNAP}/snap/command-chain/run"
1 change: 1 addition & 0 deletions snapcraft/extensions/gnome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ def get_parts_snippet(self) -> Dict[str, Any]:
"source": str(source),
"plugin": "make",
"build-snaps": [sdk_snap],
"make-parameters": ["PLATFORM_PLUG=gnome-platform"],
**gpu_opts,
},
}
Expand Down