chore: use pathlib to interact with craft-parts#5981
Draft
EdmilsonRodrigues wants to merge 1 commit intocanonical:mainfrom
Draft
chore: use pathlib to interact with craft-parts#5981EdmilsonRodrigues wants to merge 1 commit intocanonical:mainfrom
EdmilsonRodrigues wants to merge 1 commit intocanonical:mainfrom
Conversation
bepri
reviewed
Jan 26, 2026
Member
There was a problem hiding this comment.
I'm happy with what these changes are doing, but I'm curious what caused them to be needed? I don't see any obvious link between this module's changes and Craft Parts
Contributor
Author
There was a problem hiding this comment.
It's because of these lines in snapcraft/parts/lifecycle.py (line 693):
migrated_files = step_info.state.files
patcher = Patcher(dynamic_linker=linker, root_path=step_info.prime_dir)
elf_files = elf_utils.get_elf_files_from_list(step_info.prime_dir, migrated_files)migrated_files has changed its type to be an Iterable[Path] instead of Interable[str]
Contributor
Author
There was a problem hiding this comment.
Sure I could convert it there to string also, but I preferred to changing here to use pathlib instead.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust calls to functions of craft-parts to use pathlib after change in craft-parts API.
make lint && make test.