feat: ros2 lyrical extension (core26)#6053
Draft
florcabral wants to merge 2 commits intocanonical:mainfrom
Draft
feat: ros2 lyrical extension (core26)#6053florcabral wants to merge 2 commits intocanonical:mainfrom
florcabral wants to merge 2 commits intocanonical:mainfrom
Conversation
d1c7b3f to
42745f3
Compare
mr-cal
reviewed
Feb 25, 2026
Collaborator
mr-cal
left a comment
There was a problem hiding this comment.
High-level, this looks good. Let me know when this is out of draft and you're ready for an in-depth review.
| # -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*- | ||
| # | ||
| # Copyright 2018-2022 Canonical Ltd. | ||
| # Copyright 2026 Canonical Ltd. |
Collaborator
There was a problem hiding this comment.
Canonical's copyright policy is:
Add (and keep) the year of first publication. However, it's not necessary to update the year range every year.
I have an email from Canonical's legal team, if you'd like the original reference.
So either don't change the copyrights or do:
Suggested change
| # Copyright 2026 Canonical Ltd. | |
| # Copyright 2018-2022,2026 Canonical Ltd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for ROS 2 Lyrical on core26, following the same pattern as the existing ROS 2 Humble (core22) and Jazzy (core24) extensions.
Changes include:
ros2_lyrical.py,ros2_lyrical_desktop.py,ros2_lyrical_ros_base.py,ros2_lyrical_ros_core.py, and_ros2_lyrical_meta.pyregistry.py_ros.py)test_list_extensions.pyThe extension is currently marked as experimental.
make lint && make test.