t/core/*-single-reboot: extend to core20+, use sideload instead of refresh for robustness #13741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #13741 +/- ##
=======================================
Coverage 78.90% 78.91%
=======================================
Files 1043 1043
Lines 134350 134349 -1
=======================================
+ Hits 106013 106019 +6
+ Misses 21723 21718 -5
+ Partials 6614 6612 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Meulengracht
force-pushed
the
feature/improved-single-reboot-tests
branch
from
7b122ef to
255b098
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13741 +/- ##
==========================================
+ Coverage 78.09% 78.11% +0.02%
==========================================
Files 1190 1190
Lines 158458 159184 +726
==========================================
+ Hits 123746 124353 +607
- Misses 27017 27103 +86
- Partials 7695 7728 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fri Mar 21 16:31:16 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
Meulengracht
force-pushed
the
feature/improved-single-reboot-tests
branch
3 times, most recently
from
14ca6f4 to
7e35b7c
Compare
Meulengracht
changed the title
Meulengracht
force-pushed
the
feature/improved-single-reboot-tests
branch
from
034c65f to
9412dcd
Compare
bboozzoo
reviewed
Mar 19, 2025
| snap download "$core_snap" --edge | ||
| unsquashfs -d base-snap "${core_snap}"_*.snap | ||
| rm "${core_snap}"_* | ||
| snap pack base-snap |
There was a problem hiding this comment.
the only purpose of repacking is to make the snap unasserted? if so would eg prinft '\0' >> core-for-repack.snap be enough? it would change the checksum, but I think it should still be possible to use the snap file, at least my local experiments show that unsquashfs is happy extracting it and I can still mount it
…it for system to be ready before continuing revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a side-load approach where it's easier to control the update behaviour and use unasserted snaps on UC18 to provide consistent updates. Before sometimes the core18 base would not update due to same revision in the image and in edge. (And we could not update gadget/kernel with unasserted snaps as they were asserted in image). This also improved the complexity of the tests.
This does not touch the failover tests, i'll probably do a separate PR for those