Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlord/snapstate: speed up some slow tests #15208

Merged

Conversation

maykathm
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.26%. Comparing base (d6d95f0) to head (7fdd290).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15208      +/-   ##
==========================================
+ Coverage   78.09%   78.26%   +0.17%     
==========================================
  Files        1190     1195       +5     
  Lines      158458   160098    +1640     
==========================================
+ Hits       123746   125301    +1555     
- Misses      27017    27072      +55     
- Partials     7695     7725      +30     
Flag Coverage Δ
unittests 78.26% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 14, 2025

Fri Mar 21 11:03:07 UTC 2025

Spread tests skipped

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can add the Skip Spread label to this one

@miguelpires miguelpires added the Skip spread Indicate that spread job should not run label Mar 21, 2025
@miguelpires miguelpires reopened this Mar 21, 2025
@maykathm maykathm merged commit c3c1dd3 into canonical:master Mar 21, 2025
135 of 137 checks passed
@maykathm maykathm deleted the SNAPDENG-34369-fix-long-running-unit-tests branch March 21, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants