tests: add snap version invariant during restore phase of testing - #16465
Open
maykathm wants to merge 9 commits into
Open
tests: add snap version invariant during restore phase of testing#16465maykathm wants to merge 9 commits into
maykathm wants to merge 9 commits into
Conversation
|
Mon Jun 15 18:58:44 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
2 times, most recently
from
January 20, 2026 17:48
24a3f30 to
7e18134
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16465 +/- ##
==========================================
+ Coverage 79.07% 79.13% +0.05%
==========================================
Files 1370 1388 +18
Lines 190982 193529 +2547
Branches 2465 2466 +1
==========================================
+ Hits 151028 153149 +2121
- Misses 30864 31189 +325
- Partials 9090 9191 +101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
5 times, most recently
from
January 21, 2026 17:27
f0467d1 to
10245b2
Compare
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
3 times, most recently
from
January 29, 2026 09:14
a28b5ab to
6db1093
Compare
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
from
February 2, 2026 08:53
6db1093 to
9570b76
Compare
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
3 times, most recently
from
February 24, 2026 15:17
3f919fc to
dac158b
Compare
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
from
May 4, 2026 11:52
dac158b to
98e617f
Compare
maykathm
marked this pull request as ready for review
May 7, 2026 07:38
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
from
May 7, 2026 12:29
f106dd5 to
a6b7b7b
Compare
maykathm
force-pushed
the
maykathm/SNAPDENG-36186-add-version-invariant-in-tests
branch
from
June 9, 2026 06:44
87de7b4 to
8ba5d3a
Compare
miguelpires
reviewed
Jun 9, 2026
miguelpires
left a comment
miguelpires
left a comment
Contributor
There was a problem hiding this comment.
there's a duplicate check
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
miguelpires
approved these changes
Jun 9, 2026
bboozzoo
reviewed
Jun 15, 2026
| # The snapd version will not be a testing version | ||
| return 0 | ||
| fi | ||
| snap version | grep snapd | MATCH "1337" || { |
Contributor
There was a problem hiding this comment.
this isn't exactly the version the test started with. I'd expect something like we do for the check-snap-mount-dir, i.e. record what's at the beginning of the test suite where we install the right package (sru, or a CI build) and check at the end that the version is still the same.
Contributor
Author
There was a problem hiding this comment.
That was my first approach but with that approach the cross-distro-reexec suite fails on amazon so I opted for this approach.
bboozzoo
reviewed
Jun 15, 2026
bboozzoo
reviewed
Jun 15, 2026
Comment on lines
+274
to
+277
| if tests.info is-snapd-from-archive && not tests.info is-reexec-enabled; then | ||
| # re-exec may be explicitly disabled in the test variant, in which case the version will not match | ||
| return 0 | ||
| fi |
Contributor
There was a problem hiding this comment.
do we still need this branch?
Contributor
Author
There was a problem hiding this comment.
Yes, because some tests disable re-exec
github-actions
Bot
added
the
Auto rerun spread
| tests.cleanup defer rm -f /snap | ||
| ;; | ||
| esac | ||
| if ! os.query is-amazon-linux; then |
Contributor
There was a problem hiding this comment.
why is this needed for this change?
Contributor
Author
There was a problem hiding this comment.
Amazon should have the cleanup in its packaging so this is a correction. It's needed for this change because without it during cleanup in the cross-distro-reexec suite when the /snap dir is removed, snapd from the RPM package is used instead of the snap.
Contributor
Author
|
This change still has issues. Eventually with enough reruns the test pass, but I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.