TPM/FDE: Use ignore action in VM - #16620
Merged
Merged
Conversation
valentindavid
added
the
Run nested
Member
|
Could we keep it when |
Contributor
Author
Sure, should that be done only if some of the spread tests above are failing (I saw you added the tag which should trigger those nested tests, right)? |
Member
|
Specifically this test: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16620 +/- ##
==========================================
- Coverage 79.05% 79.04% -0.01%
==========================================
Files 1369 1369
Lines 190708 190710 +2
Branches 2465 2465
==========================================
- Hits 150757 150756 -1
- Misses 30863 30865 +2
- Partials 9088 9089 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing/Reopening to ensure the nested tests are ran |
|
Mon May 4 14:25:18 UTC 2026 Failures:Executing:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
ernestl
reviewed
Feb 18, 2026
didrocks
force-pushed
the
use_ignore_action_in_vm
branch
from
February 18, 2026 16:17
3237147 to
a1f2e75
Compare
Contributor
Author
|
hum, even with those, the nested tests are still broken. Any guidance to run the setup locally for easier debugging? |
Member
They are not stable. Maybe a re-run will help. |
Contributor
Author
|
Some nested tests passed and not others, rerunning… |
valentindavid
approved these changes
Mar 19, 2026
Member
|
Maybe we will need to rebase. Not sure if the tests need fixes. |
didrocks
force-pushed
the
use_ignore_action_in_vm
branch
from
March 19, 2026 14:58
a1f2e75 to
d4cf681
Compare
Contributor
Author
|
(rebased, let’s see for the tests) |
Contributor
|
@didrocks sorry to ask you that again, but can you rebase once more? |
We relaxed in snapd 2.72 the preinstall check to allow installation in VMs. Now that we have the action API, an ignore action will be available to the rest of the system and users. Restore this. However, keep the current behaviour for nested tests as muinstaller does not support interactions to ignore errors.
New defaults does not permit VM.
ernestl
force-pushed
the
use_ignore_action_in_vm
branch
from
April 29, 2026 08:57
d4cf681 to
5f53efa
Compare
Member
|
Rebased |
valentindavid
approved these changes
May 4, 2026
maykathm
approved these changes
May 4, 2026
gabelluardo
pushed a commit
to gabelluardo/ubuntu-gui-testing
that referenced
this pull request
Jun 30, 2026
snapd now correctly detects a VM environement and provides a corresponding error via the actions API. See canonical/snapd#16620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our testing, we discovered that there has been some leftovers from previous snapd release to allow installation in VM without triggering the secboot ErrKind to allow users to perform the ignore action.
Restore the default then.