tests/lib/fakestore/store: use gorilla/mux, support request kill for all endpoints, improve logging - #16883
Merged
Merged
Conversation
github-actions
Bot
added
the
Run only one system
|
Fri May 8 12:13:47 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
bboozzoo
force-pushed
the
bboozzoo/fakestore-mux
branch
from
April 9, 2026 10:50
ca129b5 to
889e24e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16883 +/- ##
==========================================
- Coverage 79.05% 79.02% -0.04%
==========================================
Files 1376 1376
Lines 191152 191175 +23
Branches 2465 2465
==========================================
- Hits 151117 151075 -42
- Misses 30929 30997 +68
+ Partials 9106 9103 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zyga
reviewed
Apr 10, 2026
zyga
left a comment
zyga
left a comment
Contributor
There was a problem hiding this comment.
I don't mind this but perhaps we should get back to the (much improved) stdlib router/mux that handles all the things that (now abandoned) gorilla/mux handles?
Contributor
Author
we still use |
bboozzoo
force-pushed
the
bboozzoo/fakestore-mux
branch
from
April 15, 2026 07:40
889e24e to
197da19
Compare
bboozzoo
marked this pull request as ready for review
April 15, 2026 07:40
github-actions
Bot
removed
the
Run only one system
bboozzoo
force-pushed
the
bboozzoo/fakestore-mux
branch
from
April 23, 2026 12:44
197da19 to
affd556
Compare
bboozzoo
force-pushed
the
bboozzoo/fakestore-mux
branch
from
May 5, 2026 06:11
affd556 to
fa9c960
Compare
…all endpoints, improve logging Use gorilla/mux which we already import in daemon. Add logging middleware and improve request logging. Move kill-after to middleware and support on all endpoints. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
…e new log entry Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/fakestore-mux
branch
from
May 6, 2026 07:27
fa9c960 to
bc7cb68
Compare
bboozzoo
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use gorilla/mux which we already import in daemon.
Add logging middleware and improve request logging.
Move kill-after to middleware and support on all endpoints.
Based on #16881.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?