interfaces/builtin/microceph_support.go: do not log sudo attempt - #16950
Merged
valentindavid merged 1 commit intoMay 8, 2026
Merged
Conversation
valentindavid
marked this pull request as ready for review
April 21, 2026 11:13
github-actions
Bot
added
the
Run only one system
valentindavid
added
Needs security review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16950 +/- ##
=======================================
Coverage 79.04% 79.05%
=======================================
Files 1375 1372 -3
Lines 191012 190936 -76
Branches 2465 2465
=======================================
- Hits 150981 150938 -43
+ Misses 30924 30907 -17
+ Partials 9107 9091 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thu May 7 15:34:04 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
alfonsosanchezbeato
approved these changes
Apr 21, 2026
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks
Member
Author
|
We got confirmation that it works as intended. |
jslarraz
approved these changes
Apr 30, 2026
jslarraz
left a comment
jslarraz
left a comment
Contributor
There was a problem hiding this comment.
I don't really love this change. I don't know how hard it would be to change osd to conditionally skip the "sudo" path if running inside a snap (i.e. $SNAP is set), but it looks like a better solution for the mid term.
Considering it is -support interface, I'm ok with this for now.
jslarraz
removed
the
Needs security review
osd in microceph attempts to call sudo, which is denied. But that is known, and it spams the logs. Explicitly denying without "audit" will make it silent.
valentindavid
force-pushed
the
valentindavid/microceph-explicit-deny
branch
from
May 5, 2026 09:10
bc46aae to
fea6335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osd in microceph attempts to call sudo, which is denied. But that is known, and it spams the logs. Explicitly denying without "audit" will make it silent.
Requested from https://forum.snapcraft.io/t/suppress-audit-logging/51065