o/snapstate, o/s/backend: move SortServices into Backend.StartServices - #16992
Merged
Mohit-Chachada merged 1 commit intoMay 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16992 +/- ##
==========================================
- Coverage 79.07% 79.06% -0.01%
==========================================
Files 1375 1376 +1
Lines 191338 191361 +23
Branches 2465 2465
==========================================
+ Hits 151299 151300 +1
- Misses 30932 30948 +16
- Partials 9107 9113 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mohit-Chachada
force-pushed
the
move-SortServices-into-StartServices
branch
from
April 29, 2026 14:36
8e4a387 to
fc09d12
Compare
|
Fri May 8 08:30:00 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Mohit-Chachada
force-pushed
the
move-SortServices-into-StartServices
branch
from
May 5, 2026 11:08
fc09d12 to
6c6788a
Compare
Mohit-Chachada
added
the
Auto rerun spread
Mohit-Chachada
force-pushed
the
move-SortServices-into-StartServices
branch
from
May 7, 2026 13:57
6c6788a to
b53ecc9
Compare
Contributor
Author
|
Failed tests
These errors are not related to the changes from this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows @pedronis's feedback at https://github.com/canonical/snapd/pull/16861/changes#r3137999181
As all callers of
Backend.StartServicescurrently do (and will need to do)snap.SortServices, we just move the sorting intoBackend.StartServices.SNAPDENG-36831