Skip to content

core-initrd: increase mount burst from 5 to 128 - #16995

Merged
alfonsosanchezbeato merged 1 commit into
canonical:masterfrom
valentindavid:valentindavid/core-initrd-more-mounts
May 6, 2026
Merged

core-initrd: increase mount burst from 5 to 128#16995
alfonsosanchezbeato merged 1 commit into
canonical:masterfrom
valentindavid:valentindavid/core-initrd-more-mounts

Conversation

@valentindavid

Copy link
Copy Markdown
Member

On my VM it makes core-initrd for 26 go from more than 4 seconds to less than 3 seconds. We should probably apply something similar to core-base.

On my VM it makes core-initrd for 26 go from more than 4 seconds to
less than 3 seconds. We should probably apply something similar to
core-base.
@valentindavid valentindavid added the Run nested The PR also runs tests inluded in nested suite label Apr 29, 2026
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.05%. Comparing base (3ec19b3) to head (588d5d5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16995      +/-   ##
==========================================
- Coverage   79.06%   79.05%   -0.02%     
==========================================
  Files        1368     1372       +4     
  Lines      190680   190719      +39     
  Branches     2465     2465              
==========================================
+ Hits       150758   150766       +8     
- Misses      30835    30868      +33     
+ Partials     9087     9085       -2     
Flag Coverage Δ
unittests 79.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

Tue May 5 13:44:21 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/25120981515

Failures:

Preparing:

  • openstack-ext:ubuntu-20.04-64:tests/nested/manual/uc20-install-in-initrd:none
  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/hybrid-fde-all-key-databases:db
  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/uc-update-assets-secure-add-sbat:both
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/snapd-removes-vulnerable-snap-confine-revs:core
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/hybrid-xkb-kcmdline

Executing:

  • openstack-ext:ubuntu-18.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-20.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:encrypted
  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/muinstaller-core:install_optional_snap_and_comp
  • openstack-ext:ubuntu-22.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-24.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:plain
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • openstack-ext:ubuntu-26.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/muinstaller-real:plain
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/muinstaller-real:partial
  • openstack:ubuntu-24.04-64:tests/main/interfaces-snap-interfaces-requests-control

Restoring:

  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:encrypted
  • openstack-ext:ubuntu-22.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-22.04-64:
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:plain
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-24.04-64:
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-24.04-64:
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • openstack-ext:ubuntu-24.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-24.04-64:
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/hybrid-xkb-kcmdline
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-26.04-64:
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/muinstaller-real:plain
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-26.04-64:
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/muinstaller-real:partial
  • openstack-ext:ubuntu-26.04-64:tests/nested/manual/
  • openstack-ext:ubuntu-26.04-64:
  • openstack:ubuntu-24.04-64:tests/cross/go-build:s390x
  • openstack:ubuntu-24.04-64:tests/cross/go-build:armhf
  • openstack:ubuntu-24.04-64:tests/cross/go-build:ppc64el

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)

  • openstack-ext:ubuntu-18.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-20.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-22.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-24.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack-ext:ubuntu-26.04-64:tests/nested/classic/snapshots-with-core-refresh-revert
  • openstack:ubuntu-24.04-64:tests/main/i18n

@alfonsosanchezbeato
alfonsosanchezbeato merged commit 33fc8ca into canonical:master May 6, 2026
309 of 352 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Run nested The PR also runs tests inluded in nested suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants