cmd/snap-update-ns: ensure that a /tmp/.X11-unix created inside the mount ns has expected permissions - #17001
Merged
Conversation
github-actions
Bot
added
the
Run only one system
bboozzoo
force-pushed
the
bboozzoo/hint-tmp-x11-unix
branch
from
April 30, 2026 09:25
257ea82 to
91dd977
Compare
zyga
approved these changes
Apr 30, 2026
|
Tue May 19 14:03:01 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17001 +/- ##
==========================================
- Coverage 79.06% 79.06% -0.01%
==========================================
Files 1375 1380 +5
Lines 191085 191171 +86
Branches 2465 2465
==========================================
+ Hits 151075 151141 +66
- Misses 30917 30934 +17
- Partials 9093 9096 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bboozzoo
marked this pull request as ready for review
April 30, 2026 12:07
github-actions
Bot
removed
the
Run only one system
Contributor
Author
|
@Saviq can you try the snapd snap from this PR? |
miguelpires
approved these changes
May 5, 2026
…ount ns has expected permissions The /tmp/.X11-unix target path created inside the snap's mount ns is hidden when the mount added by the x11 interface is executed. However, to keep things consistent we should ensure that it is created with a reasonable mode, which matches what a typical /tmp/.X11-unix directory would have. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/hint-tmp-x11-unix
branch
from
May 6, 2026 06:48
91dd977 to
1ae4d58
Compare
bboozzoo
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /tmp/.X11-unix target path created inside the snap's mount ns is hidden when the mount added by the x11 interface is executed. However, to keep things consistent we should ensure that it is created with a reasonable mode, which matches what a typical /tmp/.X11-unix directory would have.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?