Skip to content

many: replace rootPath with dirs.GlobalRootDir #17007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiocazzolato merged 4 commits into from
May 20, 2026
Merged

many: replace rootPath with dirs.GlobalRootDir #17007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10e8d96
s/apparmor: replacerootPath with dirs.GlobalRootDir
natibek Apr 30, 2026
c5b7c2c
s/apparmor: use dirs.SetRootDir directly in tests
natibek May 1, 2026
a8fcb89
many: replace rootPath with dirs.GlobalRootDir
natibek May 1, 2026
4b6669d
s/apparmor: set the GlobalRootDir in apparmorSuite.SetUpTest and stor…
natibek May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions overlord/configstate/configcore/prompting_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ func (s *promptingSuite) SetUpTest(c *C) {
))
// mock the presence of the notification socket
os.MkdirAll(apparmor.NotifySocketPath, 0o755)
// mock the presence of permstable32_version with supported version
s.AddCleanup(apparmor.MockFsRootPath(dirs.GlobalRootDir))
os.MkdirAll(filepath.Join(dirs.GlobalRootDir, "sys/kernel/security/apparmor/features/policy"), 0o755)
os.WriteFile(filepath.Join(dirs.GlobalRootDir, "sys/kernel/security/apparmor/features/policy/permstable32_version"), []byte("0x000002"), 0o644)

Expand Down
15 changes: 1 addition & 14 deletions sandbox/apparmor/apparmor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,11 +555,6 @@ var (
// system, use a predictable search path for finding the parser.
parserSearchPath = "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"

// Filesystem root defined locally to avoid dependency on the
// 'dirs' package
// TODO: replace rootPath with dirs.GlobalRootDir, since dirs is used elsewhere
rootPath = "/"

// hostAbi30File is the path to the apparmor "3.0" ABI file and is typically
// /etc/apparmor.d/abi/3.0. It is not present on all systems. It is notably
// absent when using apparmor 2.x. The variable reacts to changes to global
Expand All @@ -575,7 +570,7 @@ const featuresSysPath = "sys/kernel/security/apparmor/features"
// FeaturesSysDir returns the path to the AppArmor features sysfs, which is
// /sys/kernel/security/apparmor/features, relative to the current root dir.
func FeaturesSysDir() string {
return filepath.Join(rootPath, featuresSysPath)
return filepath.Join(dirs.GlobalRootDir, featuresSysPath)
}

type appArmorProber interface {
Expand Down Expand Up @@ -1110,11 +1105,3 @@ func MockParserSearchPath(new string) (restore func()) {
parserSearchPath = oldAppArmorParserSearchPath
}
}

func MockFsRootPath(path string) (restorer func()) {
old := rootPath
rootPath = path
return func() {
rootPath = old
}
}
111 changes: 37 additions & 74 deletions sandbox/apparmor/apparmor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,16 @@ func TestApparmor(t *testing.T) {

type apparmorSuite struct {
testutil.BaseTest
fakeroot string
}

var _ = Suite(&apparmorSuite{})

func (s *apparmorSuite) SetUpTest(c *C) {
s.BaseTest.SetUpTest(c)

dirs.SetRootDir(c.MkDir())
s.fakeroot = c.MkDir()
dirs.SetRootDir(s.fakeroot)
s.AddCleanup(func() { dirs.SetRootDir("") })

s.AddCleanup(func() {
Expand All @@ -77,9 +79,6 @@ func (*apparmorSuite) TestAppArmorParser(c *C) {
}

func (*apparmorSuite) TestAppArmorInternalAppArmorParserAbi3(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

libSnapdDir := filepath.Join(dirs.SnapMountDir, "/snapd/42/usr/lib/snapd")
parser := filepath.Join(libSnapdDir, "apparmor_parser")
c.Assert(os.MkdirAll(libSnapdDir, 0755), IsNil)
Expand Down Expand Up @@ -108,9 +107,6 @@ func (*apparmorSuite) TestAppArmorInternalAppArmorParserAbi3(c *C) {
}

func (*apparmorSuite) TestAppArmorInternalAppArmorParserAbi4(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

libSnapdDir := filepath.Join(dirs.SnapMountDir, "/snapd/42/usr/lib/snapd")
parser := filepath.Join(libSnapdDir, "apparmor_parser")
c.Assert(os.MkdirAll(libSnapdDir, 0755), IsNil)
Expand Down Expand Up @@ -268,44 +264,40 @@ func (*apparmorSuite) TestMockAppArmorFeatures(c *C) {
const featuresSysPath = "sys/kernel/security/apparmor/features"

func (s *apparmorSuite) TestProbeAppArmorKernelFeatures(c *C) {
d := c.MkDir()

// Pretend that apparmor kernel features directory doesn't exist.
restore := apparmor.MockFsRootPath(d)
defer restore()
features, err := apparmor.ProbeKernelFeatures()
c.Assert(os.IsNotExist(err), Equals, true)
c.Check(features, DeepEquals, []string{})

// Pretend that apparmor kernel features directory exists but is empty.
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath), 0755), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
c.Check(features, DeepEquals, []string{})

// Pretend that apparmor kernel features directory contains some entries.
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "foo"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "bar"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "xyz"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "foo"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "bar"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "xyz"), 0755), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
c.Check(features, DeepEquals, []string{"bar", "foo", "xyz"})

// Also test sub-features features
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "foo", "baz"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "foo", "qux"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "foo", "baz"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "foo", "qux"), 0755), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
c.Check(features, DeepEquals, []string{"bar", "foo", "foo:baz", "foo:qux", "xyz"})

// But boolean file features are not included
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "bar", "feat1"), nil, 0o644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "bar", "feat1"), nil, 0o644), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
c.Check(features, DeepEquals, []string{"bar", "foo", "foo:baz", "foo:qux", "xyz"})

// Also test that prompt feature is read from permstable32 if it exists
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "policy"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "policy"), 0755), IsNil)
for _, testCase := range []struct {
permstableContent string
expectedSuffixes []string
Expand Down Expand Up @@ -343,7 +335,7 @@ func (s *apparmorSuite) TestProbeAppArmorKernelFeatures(c *C) {
[]string{"prompt"},
},
} {
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32"), []byte(testCase.permstableContent), 0644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32"), []byte(testCase.permstableContent), 0644), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
expected := []string{"bar", "foo", "foo:baz", "foo:qux", "policy"}
Expand All @@ -355,9 +347,9 @@ func (s *apparmorSuite) TestProbeAppArmorKernelFeatures(c *C) {
}

// Set permstable32 to good value
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32"), []byte("allow deny prompt"), 0644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32"), []byte("allow deny prompt"), 0644), IsNil)
// Create notify directory
c.Assert(os.Mkdir(filepath.Join(d, featuresSysPath, "policy", "notify"), 0755), IsNil)
c.Assert(os.Mkdir(filepath.Join(s.fakeroot, featuresSysPath, "policy", "notify"), 0755), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
expected := []string{"bar", "foo", "foo:baz", "foo:qux", "policy", "policy:notify", "policy:permstable32:prompt", "xyz"}
Expand All @@ -381,7 +373,7 @@ func (s *apparmorSuite) TestProbeAppArmorKernelFeatures(c *C) {
[]string{"dbus", "file", "network"},
},
} {
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "notify", "user"), []byte(testCase.userContent), 0644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "notify", "user"), []byte(testCase.userContent), 0644), IsNil)
features, err = apparmor.ProbeKernelFeatures()
c.Assert(err, IsNil)
expected = []string{"bar", "foo", "foo:baz", "foo:qux", "policy", "policy:notify"}
Expand All @@ -394,18 +386,14 @@ func (s *apparmorSuite) TestProbeAppArmorKernelFeatures(c *C) {
}

func (s *apparmorSuite) TestProbeAppArmorKernelFeaturesPermstable32Version(c *C) {
d := c.MkDir()

// Pretend that apparmor kernel features directory doesn't exist.
restore := apparmor.MockFsRootPath(d)
defer restore()
version, err := apparmor.ProbeKernelFeaturesPermstable32Version()
c.Assert(os.IsNotExist(err), Equals, true)
c.Check(version, Equals, int64(0))

// Pretend that the permstable32_version file exists but is malformed.
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "policy"), 0o755), IsNil)
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32_version"), nil, 0o644), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "policy"), 0o755), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32_version"), nil, 0o644), IsNil)
version, err = apparmor.ProbeKernelFeaturesPermstable32Version()
c.Assert(errors.Is(err, strconv.ErrSyntax), Equals, true)
c.Check(version, Equals, int64(0))
Expand All @@ -432,7 +420,7 @@ func (s *apparmorSuite) TestProbeAppArmorKernelFeaturesPermstable32Version(c *C)
0x1234567890abcdef,
},
} {
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32_version"), []byte(testCase.str), 0o644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32_version"), []byte(testCase.str), 0o644), IsNil)
version, err = apparmor.ProbeKernelFeaturesPermstable32Version()
c.Check(err, IsNil)
c.Check(version, Equals, testCase.ver)
Expand Down Expand Up @@ -485,19 +473,19 @@ func probeOneVersionDependentParserFeature(c *C, known *[]string, parserPath, pa

type parserFeatureTestSuite struct {
testutil.BaseTest
d string
binDir string
fakeroot string
binDir string
}

var _ = Suite(&parserFeatureTestSuite{})

func (s *parserFeatureTestSuite) SetUpTest(c *C) {
s.d = c.MkDir()
s.fakeroot = c.MkDir()
// This is used to find related parser files and isolates us from the host.
dirs.SetRootDir(s.d)
dirs.SetRootDir(s.fakeroot)
s.AddCleanup(func() { dirs.SetRootDir("") })

s.binDir = filepath.Join(s.d, "bin")
s.binDir = filepath.Join(s.fakeroot, "bin")
err := os.Mkdir(s.binDir, 0o755)
c.Assert(err, IsNil)

Expand Down Expand Up @@ -611,16 +599,12 @@ func (s *parserFeatureTestSuite) TestInternalParser(c *C) {

func (s *apparmorSuite) TestInterfaceSystemKey(c *C) {
apparmor.FreshAppArmorAssessment()

d := c.MkDir()
restore := apparmor.MockFsRootPath(d)
defer restore()
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "policy"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "network"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "policy"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "network"), 0755), IsNil)

mockParserCmd := testutil.MockCommand(c, "apparmor_parser", fakeParserScript("4.0.1"))
defer mockParserCmd.Restore()
restore = apparmor.MockParserSearchPath(mockParserCmd.BinDir())
restore := apparmor.MockParserSearchPath(mockParserCmd.BinDir())
defer restore()

apparmor.ProbedLevel()
Expand Down Expand Up @@ -654,15 +638,12 @@ func (s *apparmorSuite) TestAppArmorParserMtime(c *C) {
func (s *apparmorSuite) TestFeaturesProbedOnce(c *C) {
apparmor.FreshAppArmorAssessment()

d := c.MkDir()
restore := apparmor.MockFsRootPath(d)
defer restore()
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "policy"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "network"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "policy"), 0755), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "network"), 0755), IsNil)

mockParserCmd := testutil.MockCommand(c, "apparmor_parser", fakeParserScript("4.0.1"))
defer mockParserCmd.Restore()
restore = apparmor.MockParserSearchPath(mockParserCmd.BinDir())
restore := apparmor.MockParserSearchPath(mockParserCmd.BinDir())
defer restore()

features, err := apparmor.KernelFeatures()
Expand All @@ -673,7 +654,7 @@ func (s *apparmorSuite) TestFeaturesProbedOnce(c *C) {
c.Check(features, DeepEquals, []string{"cap-audit-read", "cap-bpf", "include-if-exists", "io-uring", "mqueue", "mqueue-posix", "prompt", "qipcrtr-socket", "tags", "unconfined", "unsafe", "userns", "xdp"})

// this makes probing fails but is not done again
err = os.RemoveAll(d)
err = os.RemoveAll(s.fakeroot)
c.Assert(err, IsNil)

_, err = apparmor.KernelFeatures()
Expand All @@ -688,10 +669,6 @@ func (s *apparmorSuite) TestFeaturesProbedOnce(c *C) {
}

func (s *apparmorSuite) TestPromptingSupported(c *C) {
d := c.MkDir()
restore := apparmor.MockFsRootPath(d)
defer restore()

goodKernelFeatures := []string{"policy:permstable32:prompt"}
goodKernelFeaturesWithNotify := []string{"policy:permstable32:prompt", "policy:notify", "policy:notify:user:file"}
goodParserFeatures := []string{"prompt"}
Expand Down Expand Up @@ -770,23 +747,23 @@ func (s *apparmorSuite) TestPromptingSupported(c *C) {
// Create a file at the notify path, doesn't matter what kind of file.
// The actual file is a socket, but a directory will do here for convenience.
c.Assert(os.MkdirAll(apparmor.NotifySocketPath, 0o755), IsNil)
restore = apparmor.MockFeatures(goodKernelFeatures, nil, goodParserFeatures, nil)
restore := apparmor.MockFeatures(goodKernelFeatures, nil, goodParserFeatures, nil)
defer restore()

supported, reason := apparmor.PromptingSupported()
c.Check(supported, Equals, false)
c.Check(reason, Equals, "apparmor kernel permissions table version must be at least 2 for prompting to be supported, but version could not be read")

// Create permstable32_version file with a version too early
c.Assert(os.MkdirAll(filepath.Join(d, featuresSysPath, "policy"), 0o755), IsNil)
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32_version"), []byte("0x000001"), 0o644), IsNil)
c.Assert(os.MkdirAll(filepath.Join(s.fakeroot, featuresSysPath, "policy"), 0o755), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32_version"), []byte("0x000001"), 0o644), IsNil)

supported, reason = apparmor.PromptingSupported()
c.Check(supported, Equals, false)
c.Check(reason, Equals, "apparmor kernel permissions table version must be at least 2 for prompting to be supported, but version is 1")

// Create permstable32_version file with a sufficient version
c.Assert(os.WriteFile(filepath.Join(d, featuresSysPath, "policy", "permstable32_version"), []byte("0x000002"), 0o644), IsNil)
c.Assert(os.WriteFile(filepath.Join(s.fakeroot, featuresSysPath, "policy", "permstable32_version"), []byte("0x000002"), 0o644), IsNil)

for _, kernelFeatures := range [][]string{goodKernelFeatures, goodKernelFeaturesWithNotify} {
restore := apparmor.MockFeatures(kernelFeatures, nil, goodParserFeatures, nil)
Expand Down Expand Up @@ -960,9 +937,6 @@ func (s *apparmorSuite) TestUpdateHomedirsTunableWriteFail(c *C) {
}

func (s *apparmorSuite) TestUpdateHomedirsTunableHappy(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

err := apparmor.UpdateHomedirsTunable([]string{"/home/a", "/dir2"})
c.Assert(err, IsNil)
configFile := filepath.Join(dirs.GlobalRootDir, "/etc/apparmor.d/tunables/home.d/snapd")
Expand All @@ -980,9 +954,6 @@ func (s *apparmorSuite) TestUpdateHomedirsTunableHappyNoDirs(c *C) {
}

func (s *apparmorSuite) TestSnapdAppArmorSupportsReexecImpl(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

// with no info file should indicate it does not support reexec
c.Check(apparmor.SnapdAppArmorSupportsRexecImpl(), Equals, false)

Expand All @@ -1005,9 +976,6 @@ func (s *apparmorSuite) TestSetupConfCacheDirs(c *C) {
}

func (s *apparmorSuite) TestSetupConfCacheDirsWithInternalApparmor(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

libSnapdDir := filepath.Join(dirs.SnapMountDir, "/snapd/42/usr/lib/snapd")
parser := filepath.Join(libSnapdDir, "apparmor_parser")
c.Assert(os.MkdirAll(libSnapdDir, 0755), IsNil)
Expand Down Expand Up @@ -1036,9 +1004,7 @@ func (s *apparmorSuite) TestSetupNotifySocketPath(c *C) {
}

func (s *apparmorSuite) TestSystemAppArmorLoadsSnapPolicyErr(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)
fakeApparmorFunctionsPath := filepath.Join(fakeroot, "/lib/apparmor/functions")
fakeApparmorFunctionsPath := filepath.Join(s.fakeroot, "/lib/apparmor/functions")
err := os.MkdirAll(filepath.Dir(fakeApparmorFunctionsPath), 0750)
c.Assert(err, IsNil)

Expand All @@ -1064,14 +1030,11 @@ func (s *apparmorSuite) TestSystemAppArmorLoadsSnapPolicyErr(c *C) {
}

func (s *apparmorSuite) TestSystemAppArmorLoadsSnapPolicy(c *C) {
fakeroot := c.MkDir()
dirs.SetRootDir(fakeroot)

// systemAppArmorLoadsSnapPolicy() will look at this path so it
// needs to be the real path, not a faked one
dirs.SnapAppArmorDir = dirs.SnapAppArmorDir[len(fakeroot):]
dirs.SnapAppArmorDir = dirs.SnapAppArmorDir[len(s.fakeroot):]

fakeApparmorFunctionsPath := filepath.Join(fakeroot, "/lib/apparmor/functions")
fakeApparmorFunctionsPath := filepath.Join(s.fakeroot, "/lib/apparmor/functions")
err := os.MkdirAll(filepath.Dir(fakeApparmorFunctionsPath), 0755)
c.Assert(err, IsNil)

Expand Down
8 changes: 4 additions & 4 deletions sandbox/apparmor/notify/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (

. "gopkg.in/check.v1"

"github.com/snapcore/snapd/sandbox/apparmor"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/sandbox/apparmor/notify"
"github.com/snapcore/snapd/testutil"
)
Expand Down Expand Up @@ -125,8 +125,7 @@ func (s *versionSuite) TestVersionsLikelySupportedChecks(c *C) {
c.Assert(testCase.expectedSupport, HasLen, len(notify.Versions))

tmpdir := c.MkDir()
restore := apparmor.MockFsRootPath(tmpdir)
defer restore()
dirs.SetRootDir(tmpdir)

@olivercalder olivercalder May 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible we'd want to do this in SetUpTest if we need to modify GlobalRootDir for other tests too, but if not, this is fine.

@natibek natibek May 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only test in version_test.go that modifies GlobalRootDir and it also needs to modify it for each iteration.


versionsDir := filepath.Join(tmpdir, "sys/kernel/security/apparmor/features/policy/notify_versions")

Expand All @@ -140,7 +139,7 @@ func (s *versionSuite) TestVersionsLikelySupportedChecks(c *C) {
c.Assert(f.Close(), IsNil)
}

restore = notify.MockApparmorMetadataTagsSupportedByKernel(func() bool {
restore := notify.MockApparmorMetadataTagsSupportedByKernel(func() bool {
return testCase.metadataTagsSupported
})
defer restore()
Expand All @@ -151,6 +150,7 @@ func (s *versionSuite) TestVersionsLikelySupportedChecks(c *C) {
c.Check(supported, Equals, testCase.expectedSupport[i], Commentf("version: %d\ntestCase: %+v", version, testCase))
}
}
dirs.SetRootDir("")
}

var fakeVersions = []notify.VersionAndCheck{
Expand Down
Loading
Loading