Skip to content

o/c/c/ntp: integrate NTP configuration options into snapd #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzo-medici wants to merge 27 commits into
base: master
Choose a base branch
from
Open

o/c/c/ntp: integrate NTP configuration options into snapd #17022

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6f00cc7
o/c/c/ntp: configure NTP servers from snapd options
lorenzo-medici May 5, 2026
be4e535
o/c/c/ntp: configure additional NTP options RootDistance, PollInterva…
lorenzo-medici May 5, 2026
d4bc54c
o/c/c/ntp: skip writing the configuration if it has not changed, nami…
lorenzo-medici May 8, 2026
067e83c
o/c/c/ntp_test: added tests for getting and setting core.system.ntp c…
lorenzo-medici May 12, 2026
ad1be51
o/c/c/ntp: support unsetting system.ntp key by deleting the config file
lorenzo-medici May 12, 2026
86af750
o/c/c/ntp: removed validation in handle function, ignore unsupported …
lorenzo-medici May 12, 2026
6a7840e
o/c/c/ntp_test: fixed import errors in unit tests
lorenzo-medici May 13, 2026
0f4b81f
o/c/c/ntp: improved handling of empty options in configuration file
lorenzo-medici May 13, 2026
f631487
o/c/c/ntp_test: improve unit test coverage
lorenzo-medici May 14, 2026
c48427f
o/c/c/ntp: do not restart systemd-timesyncd during image build
lorenzo-medici Jun 1, 2026
e602fbb
o/c/c/ntp: make NTPConfigurationDeepEqual unexported
lorenzo-medici Jun 1, 2026
86adba6
o/c/c/ntp: replace strings.Split with strings.Fields to improve serve…
lorenzo-medici Jun 1, 2026
542da8d
o/c/c/ntp_test: make tests more robust by checking more errors on fil…
lorenzo-medici Jun 1, 2026
b3d660e
o/c/c/ntp: improve string formatting
lorenzo-medici Jun 1, 2026
4941937
o/c/c/handlers: comment for NTP options changed to system.ntp.* to in…
lorenzo-medici Jun 1, 2026
6e6010e
o/c/c/ntp: rename snap config options to improve clarity
lorenzo-medici Jun 5, 2026
fdf9fcc
o/c/c/ntp: input format for intervals changed from systemd.time strin…
lorenzo-medici Jun 8, 2026
8d229f4
go.mod: added github.com/coreos/go-systemd module
lorenzo-medici Jun 9, 2026
175a49a
o/c/c/ntp: improved server name input validation
lorenzo-medici Jun 19, 2026
a79fb61
o/c/c/ntp: user-provided strings are rejected if containing leading o…
lorenzo-medici Jun 19, 2026
16e4ecb
o/c/c/ntp: test cleanup
lorenzo-medici Jun 19, 2026
1bc2c4f
o/c/c/ntp: reject negative duration values explicitly with clear message
lorenzo-medici Jun 29, 2026
552aed5
o/c/c/ntp: simplify function comparing {min,max}-poll-interval values
lorenzo-medici Jun 30, 2026
30b0226
o/c/c/ntp: added docstrings for getNTPFromSystem and getNTPFromSystem…
lorenzo-medici Jun 30, 2026
49db17e
tests/core: added spread test for setting timesyncd options through s…
lorenzo-medici Jul 1, 2026
01ed5e5
tests/core/ntp-config: check additional unmodified field after succes…
lorenzo-medici Jul 2, 2026
9429cf1
o/c/c/ntp: added comments about writing to main configuration file an…
lorenzo-medici Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ require (

require (
github.com/cilium/ebpf v0.9.1
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf
go.etcd.io/bbolt v1.3.9
)

Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ github.com/chai2010/gettext-go v1.0.3 h1:9liNh8t+u26xl5ddmWLmsOsdNLwkdRTg5AG+JnT
github.com/chai2010/gettext-go v1.0.3/go.mod h1:y+wnP2cHYaVj19NZhYKAwEMH2CI1gNHeQQ+5AjwawxA=
github.com/cilium/ebpf v0.9.1 h1:64sn2K3UKw8NbP/blsixRpF3nXuyhz/VjRlRzvlBRu4=
github.com/cilium/ebpf v0.9.1/go.mod h1:+OhNOIXx/Fnu1IE8bJz2dzOA+VSfyTfdNUVdlQnxUFY=
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf h1:iW4rZ826su+pqaw19uhpSCzhj44qo35pNgKFGqzDKkU=
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/frankban/quicktest v1.2.2/go.mod h1:Qh/WofXFeiAFII1aEBu529AtJo6Zg2VHscnEsbBnJ20=
Expand Down
15 changes: 8 additions & 7 deletions overlord/configstate/configcore/export_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,14 @@ import (
)

var (
UpdatePiConfig = updatePiConfig
SwitchHandlePowerKey = switchHandlePowerKey
SwitchDisableService = switchDisableService
UpdateKeyValueStream = updateKeyValueStream
AddFSOnlyHandler = addFSOnlyHandler
FilesystemOnlyApply = filesystemOnlyApply
UpdateHomedirsConfig = updateHomedirsConfig
UpdatePiConfig = updatePiConfig
SwitchHandlePowerKey = switchHandlePowerKey
SwitchDisableService = switchDisableService
UpdateKeyValueStream = updateKeyValueStream
AddFSOnlyHandler = addFSOnlyHandler
FilesystemOnlyApply = filesystemOnlyApply
UpdateHomedirsConfig = updateHomedirsConfig
NTPConfigurationDeepEqual = ntpConfigurationDeepEqual

DoExperimentalApparmorPromptingDaemonRestart = doExperimentalApparmorPromptingDaemonRestart
)
Expand Down
3 changes: 3 additions & 0 deletions overlord/configstate/configcore/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ func init() {
// system.motd
addFSOnlyHandler(validateMotdConfiguration, handleMotdConfiguration, coreOnly)

// system.ntp.*
addFSOnlyHandler(validateNTPSettings, handleNTPConfiguration, coreOnly)

sysconfig.ApplyFilesystemOnlyDefaultsImpl = filesystemOnlyApply
}

Expand Down
Loading
Loading