secboot: complete the decision for auto-repair/reprovision - #17386
Open
valentindavid wants to merge 4 commits into
Open
secboot: complete the decision for auto-repair/reprovision#17386valentindavid wants to merge 4 commits into
valentindavid wants to merge 4 commits into
Conversation
valentindavid
added
the
Run nested
github-actions
Bot
added
the
Run only one system
|
Fri Jul 24 17:04:39 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)
|
valentindavid
force-pushed
the
valentindavid/status-api-reprovision
branch
from
July 21, 2026 13:29
760871f to
a8ad444
Compare
github-actions
Bot
added
the
Needs Documentation -auto-
valentindavid
force-pushed
the
valentindavid/status-api-reprovision
branch
3 times, most recently
from
July 24, 2026 06:42
2a42006 to
ab5c05f
Compare
github-actions
Bot
removed
the
Needs Documentation -auto-
valentindavid
marked this pull request as ready for review
July 24, 2026 06:42
github-actions
Bot
removed
the
Run only one system
valentindavid
force-pushed
the
valentindavid/status-api-reprovision
branch
from
July 24, 2026 07:21
ab5c05f to
a1e889f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17386 +/- ##
==========================================
+ Coverage 78.84% 78.85% +0.01%
==========================================
Files 1411 1407 -4
Lines 196727 196843 +116
Branches 2462 2462
==========================================
+ Hits 155111 155225 +114
- Misses 32280 32283 +3
+ Partials 9336 9335 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
valentindavid
force-pushed
the
valentindavid/status-api-reprovision
branch
from
July 24, 2026 08:00
a1e889f to
baf70d4
Compare
pedronis
reviewed
Jul 24, 2026
| DiskModel() string | ||
| } | ||
|
|
||
| type RemedialActions struct { |
Contributor
There was a problem hiding this comment.
can give a doc comment to this? and also to the fields?
ZeyadYasser
reviewed
Jul 24, 2026
| DiskModel() string | ||
| } | ||
|
|
||
| // RemedialActions is a set of action recommended to repair detected |
Contributor
There was a problem hiding this comment.
Suggested change
| // RemedialActions is a set of action recommended to repair detected | |
| // RemedialActions is a set of actions recommended to repair detected |
| // If the attempt fails, then it means a reprovision is required. | ||
| AttemptRepair bool | ||
| // RequireReprovision tells whether issues require a reprovision | ||
| // and it was detected that auto repair would not be enough. |
Contributor
There was a problem hiding this comment.
Suggested change
| // and it was detected that auto repair would not be enough. | |
| // and it was detected that auto-repair would not be enough. |
| type repairState struct { | ||
| Result AutoRepairResult `json:"result"` | ||
| Result AutoRepairResult `json:"result"` | ||
| Recommendations []RecommendedRemedialAction `json:"recommendations,omitempty"` |
Contributor
There was a problem hiding this comment.
does it make sense for future proofing to make it map[RecommendedRemedialAction]any? so that if we need to augment an action with args we could because we will be stuck with that API unless we deprecate the field.
Member
Author
There was a problem hiding this comment.
In order to add "input" to the action? We can add extra fields for them.
Contributor
There was a problem hiding this comment.
how would we add extra fields if it's a list of strings?
Contributor
There was a problem hiding this comment.
do you mean something like: recommendation-args?
ZeyadYasser
approved these changes
Jul 28, 2026
ZeyadYasser
left a comment
ZeyadYasser
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Thank you! only a remark on recommendation args
| type repairState struct { | ||
| Result AutoRepairResult `json:"result"` | ||
| Result AutoRepairResult `json:"result"` | ||
| Recommendations []RecommendedRemedialAction `json:"recommendations,omitempty"` |
Contributor
There was a problem hiding this comment.
how would we add extra fields if it's a list of strings?
| type repairState struct { | ||
| Result AutoRepairResult `json:"result"` | ||
| Result AutoRepairResult `json:"result"` | ||
| Recommendations []RecommendedRemedialAction `json:"recommendations,omitempty"` |
Contributor
There was a problem hiding this comment.
do you mean something like: recommendation-args?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.