asserts: disallow duplicate devices in request messages - #17401
Open
st3v3nmw wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens validation in the asserts request-message parsing layer by rejecting repeated device identifiers in the devices header, ensuring request targeting is explicit and unambiguous within snapd’s assertion processing.
Changes:
- Detect and reject duplicate entries in the
devicesheader when decoding request-message assertions. - Add a unit test to confirm duplicate devices now produce a deterministic decode error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| asserts/messages.go | Adds duplicate detection to parseDevices while decoding request-message headers. |
| asserts/messages_test.go | Extends invalid decode coverage to assert duplicates in devices are rejected with the expected error. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17401 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 1410 1406 -4
Lines 196929 196862 -67
Branches 2498 2498
=======================================
- Hits 155208 155165 -43
+ Misses 32367 32347 -20
+ Partials 9354 9350 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Wed Jul 29 07:21:55 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)
|
st3v3nmw
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing the
devicesheader of a request message, snapd previously accepted repeated values without complaint. This PR fixes that.checkClusterDevicesinasserts/cluster.goalso fails on error, instead of silently deduplicating.