Skip to content

tests/main/system-usernames-hooks: a snap using system-usernames and hooks - #17405

Open
bboozzoo wants to merge 1 commit into
canonical:masterfrom
bboozzoo:bboozzoo/system-usernames-snap-with-hooks
Open

tests/main/system-usernames-hooks: a snap using system-usernames and hooks#17405
bboozzoo wants to merge 1 commit into
canonical:masterfrom
bboozzoo:bboozzoo/system-usernames-snap-with-hooks

Conversation

@bboozzoo

Copy link
Copy Markdown
Contributor

Add a spread tests which executes a refresh like scenario with a snap using system-usernames and a post-refresh hook.

Related: SNAPDENG-37266

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

…hooks

Add a spread tests which executes a refresh like scenario with a snap
using system-usernames and a post-refresh hook.

Related: SNAPDENG-37266

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.89%. Comparing base (f88962f) to head (0e4a821).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17405      +/-   ##
==========================================
+ Coverage   78.84%   78.89%   +0.05%     
==========================================
  Files        1411     1396      -15     
  Lines      196727   196606     -121     
  Branches     2462     2462              
==========================================
+ Hits       155111   155122      +11     
+ Misses      32280    32153     -127     
+ Partials     9336     9331       -5     
Flag Coverage Δ
unittests 78.89% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Fri Jul 24 11:24:44 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/30086470090

Failures:

Preparing:

  • openstack:opensuse-tumbleweed-64:

Executing:

  • garden:ubuntu-core-18-64:tests/core/gadget-kernel-refs-update-pc

Restoring:

  • openstack:opensuse-tumbleweed-64:

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)

@ZeyadYasser ZeyadYasser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you! nitpick comment

tests.cleanup defer "$TESTSTOOLS"/user-state remove-with-group snap_daemon

execute: |
"$TESTSTOOLS"/snaps-state install-local test-snapd-sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some assertions for files (e.g. "$SNAP_COMMON"/hook.log and $SNAP_COMMON/data/foo) after install and refresh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants