o/devicestate: add seed allowlist to recovery-system creation - #17410
Open
andrewphelpsj wants to merge 3 commits into
Open
o/devicestate: add seed allowlist to recovery-system creation#17410andrewphelpsj wants to merge 3 commits into
andrewphelpsj wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Run only one system
andrewphelpsj
force-pushed
the
seed-refresh-allowlist
branch
from
July 24, 2026 19:01
b903b4e to
a312da3
Compare
|
Fri Jul 24 21:21:14 UTC 2026 No spread failures reported |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17410 +/- ##
==========================================
- Coverage 78.90% 78.83% -0.08%
==========================================
Files 1393 1405 +12
Lines 196467 196821 +354
Branches 2462 2462
==========================================
+ Hits 155026 155165 +139
- Misses 32113 32309 +196
- Partials 9328 9347 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewphelpsj
commented
Jul 24, 2026
andrewphelpsj
left a comment
andrewphelpsj
left a comment
Member
Author
There was a problem hiding this comment.
Working on a spread test, will add that when finished.
| LocalComponents []snapstate.PathComponent `json:"local-components,omitempty"` | ||
| // SeedAllowlist identifies the snaps and components that may be used | ||
| // to create the recovery system. | ||
| SeedAllowlist *SeedAllowlist `json:"seed-allowlist,omitempty"` |
Member
Author
There was a problem hiding this comment.
Using nil here enables other callers to not have to provide a full allowlist. This keeps remodeling working.
andrewphelpsj
force-pushed
the
seed-refresh-allowlist
branch
2 times, most recently
from
July 24, 2026 20:07
a63363f to
d504d29
Compare
natibek
reviewed
Jul 24, 2026
|
|
||
| model_json="$(pwd)/model.json" | ||
| sed \ | ||
| -e "s/@@VERSION@@/${version}/g" \ |
Contributor
There was a problem hiding this comment.
This is nice! I'll be inspired by this for the other spread test.
andrewphelpsj
force-pushed
the
seed-refresh-allowlist
branch
from
July 24, 2026 21:10
d504d29 to
fd881cd
Compare
Let seed-refresh preserve the current seed's optional snap and component membership instead of adding every installed optional container.
andrewphelpsj
force-pushed
the
seed-refresh-allowlist
branch
from
July 24, 2026 21:11
fd881cd to
db5e584
Compare
andrewphelpsj
marked this pull request as ready for review
July 24, 2026 21:16
github-actions
Bot
removed
the
Run only one system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to enable
seed-refreshto tellcreate-recovery-systemthat it shouldn't include some snaps/components in the seed, even if it technically could. This allowlist concept enables that.I've split this into two commits to make things easier on reviewers. First commit is only additive, then I clean up some dead code in the final commit.