interfaces: fix snapd system-key comparison always failing - #17418
Open
ZeyadYasser wants to merge 2 commits into
Open
interfaces: fix snapd system-key comparison always failing#17418ZeyadYasser wants to merge 2 commits into
ZeyadYasser wants to merge 2 commits into
Conversation
The apparmor-parser-features field must be excluded from the comparison. It can only be populated by snapd, which runs apparmor_parser when writing the key to disk (see WriteSystemKey); a key generated by a client (e.g. "snap run") always leaves it unset, because the client deliberately avoids invoking the parser. Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
This fixes case where the system-key file is removed due to an ongoing regeneration the SystemKeyMismatchAdvice check will error due to missing file. Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
|
Thu Jul 30 13:27:45 UTC 2026 No spread failures reported |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17418 +/- ##
==========================================
- Coverage 78.81% 78.14% -0.68%
==========================================
Files 1406 1406
Lines 197084 198809 +1725
Branches 2498 2498
==========================================
+ Hits 155330 155354 +24
- Misses 32387 34091 +1704
+ Partials 9367 9364 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a tiny window between
snap rundetecting a mismatch due to a removedsystem-keydue to an ongoing profile regeneration and sending the advice request to snapdPOST /v2/system-info (action: advise-system-key-mismatch)where the ongoing change might have finished which triggers another profile regeneration change and with manysnap runlaunches this keeps cascading.JIRA: SNAPDENG-37268