Skip to content

[PRA-257] Automatic promotion bundle#214

Open
deusebio wants to merge 36 commits intoterraform-cc008from
pra-257-automatic-promotion-bundle
Open

[PRA-257] Automatic promotion bundle#214
deusebio wants to merge 36 commits intoterraform-cc008from
pra-257-automatic-promotion-bundle

Conversation

@deusebio
Copy link
Copy Markdown
Contributor

@deusebio deusebio commented Apr 16, 2026

Description

The current PR provides an automatic promotion script to validate the deployments on a given risk and promote to the next.

The PR introduces a new workflow that does the following steps:

  1. Extract the revisions to be validated based on a given risk
  2. Feed these revisions into the integration tests to make sure that these revisions are actually used, even if a promotion to the input risk is done in any of the charms
  3. Promote the revisions to the target risk

The three steps have been split in separate re-usable workflows.

Checklist

  • I have added or updated any relevant documentation.

The workflows provide descriptions for their inputs

@deusebio deusebio marked this pull request as draft April 16, 2026 21:40
@deusebio deusebio requested review from Batalex and welpaolo April 20, 2026 07:20
@deusebio deusebio marked this pull request as ready for review April 20, 2026 07:20
Comment thread .github/workflows/ci-uat.yaml Outdated
Comment thread .github/workflows/on_pull_request.yaml
Copy link
Copy Markdown
Contributor

@Batalex Batalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to revisit this PR and specifically the promotion script with a clear head, but I left some comments in the meantime

Comment thread .github/actions/run-test/action.yaml Outdated
Comment thread .github/scripts/charms_promotions.py Outdated
Comment thread .github/scripts/charms_promotions.py Outdated
Comment thread .github/workflows/promote-charm-revisions.yaml Outdated
Comment thread .github/scripts/charms_promotions.py
Comment thread .github/workflows/automatic-promotion.yaml
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

@deusebio I've opened a new pull request, #218, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

@Batalex Batalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we could upstream part of the logic here in a shared workflow down the road, I'm really looking forward to seeing where this automation will take us!

# See LICENSE file for licensing details.
name: Automatic promotion of bundle revisions
on:
pull_request:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: We will remove this line before merging, right?

Comment on lines +27 to +28
tox-env:
- integration-kyuubi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Since the workflow is about kyuubi, this matrix constant could be safely removed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow was only for testing and for faster development iteration. I have removed this workflow and replaced it with the full testing.

Copy link
Copy Markdown
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! I left some really minor comments

Comment thread .github/actions/run-test/action.yaml Outdated
Comment thread .github/workflows/ci-tests-single-kyuubi.yaml Outdated
Comment thread .github/workflows/promote-charm-revisions.yaml Outdated
Comment thread .github/workflows/ci-tests-single-kyuubi.yaml Outdated
Comment thread .github/workflows/generate-charm-revisions.yaml Outdated
Comment thread .github/scripts/charms_promotions.py
deusebio added 16 commits April 27, 2026 21:25
small fix

limit ci

fix

fix

fix

adding charmcraft

fix

fix

adding possibility to feed variables to tests

test workflow

adding test workflow

fix linting

fix file creation and feeding

fix

rollout all tests

script refactoring
This reverts commit efc8c1a.
deusebio and others added 18 commits April 27, 2026 21:25
Agent-Logs-Url: https://github.com/canonical/spark-k8s-bundle/sessions/b95866ae-4b13-474d-a17d-784a4ea97c70

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: deusebio <10907198+deusebio@users.noreply.github.com>
Co-authored-by: welpaolo <paolo.sottovia@canonical.com>
Signed-off-by: deusebio <edeusebio85@gmail.com>
Co-authored-by: welpaolo <paolo.sottovia@canonical.com>
Signed-off-by: deusebio <edeusebio85@gmail.com>
@deusebio deusebio force-pushed the pra-257-automatic-promotion-bundle branch from 6a9cbf7 to d946189 Compare April 27, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants