Prioritize exact matches, then prefix, then search terms#68
Merged
sergiocazzolato merged 1 commit intomainfrom Feb 10, 2026
Merged
Prioritize exact matches, then prefix, then search terms#68sergiocazzolato merged 1 commit intomainfrom
sergiocazzolato merged 1 commit intomainfrom
Conversation
Updated the image lookup logic for OpenStack to support a more robust matching strategy. Since OpenStack lacks a "family" concept similar to GCE, this PR introduces a prefix-based fallback to improve image discovery. The matching is now performed in the following priority order: 1. Exact Match: Returns immediately if the name matches perfectly. 2. Prefix Match: If no exact match exists, finds all images starting with the name and selects the newest one. 3. Term Match: If no prefix match exists, falls back to term-based matching and selects the newest one.
sergiocazzolato
temporarily deployed
to
OS_ARM64_PS7
GitHub Actions
Inactive
sergiocazzolato
temporarily deployed
to
OS_AMD64_PS7
GitHub Actions
Inactive
sergiocazzolato
temporarily deployed
to
OS_AMD64_PS7
GitHub Actions
Inactive
maykathm
approved these changes
Feb 9, 2026
Collaborator
maykathm
left a comment
maykathm
left a comment
There was a problem hiding this comment.
We could have less code duplication by creating a function out of the second and third loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the image lookup logic for OpenStack to support a more robust matching strategy. Since OpenStack lacks a "family" concept similar to GCE, this PR introduces a prefix-based fallback to improve image discovery.
The matching is now performed in the following priority order: