Skip to content

Improve how serial output is requested when server is not available in openstack #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiocazzolato merged 3 commits into from
Feb 13, 2026
Merged

Improve how serial output is requested when server is not available in openstack #71

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152d19e
Make serial output more robust when server is not available in openstack
sergiocazzolato Feb 12, 2026
2b11a1a
improving error message
sergiocazzolato Feb 12, 2026
95f843c
Fix serial output
sergiocazzolato Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spread/openstack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ var openstackSerialOutputTimeout = 30 * time.Second
var openstackSerialConsoleErr = fmt.Errorf("cannot get console output")

func (s *openstackServer) SerialOutput() (string, error) {
_, err := s.p.computeClient.GetServer(s.d.Id)
if err != nil {
// this is when the server is removed
return "", fmt.Errorf("failed to retrieve the serial console, server removed: %s", s)
}

url := fmt.Sprintf("servers/%s/action", s.d.Id)

var req struct {
Expand Down